Jupyterlab 0.31.12 #38566

zimbatm · 2018-04-07T18:08:53Z

Motivation for this change

updates and ofborg sanity check

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-04-07T18:13:40Z

Please rebase on staging: https://groups.google.com/forum/#!topic/nix-devel/IA6o_CRI0NY

zimbatm · 2018-04-07T18:17:07Z

@GrahamcOfBorg build python3Packages.jupyterlab

GrahamcOfBorg · 2018-04-07T18:28:12Z

Success on x86_64-linux (full log)

Attempted: python3Packages.jupyterlab

Partial log (click to expand)

patching script interpreter paths in /nix/store/8inm9adsvgsj649bjs3drcwnx7dzywc9-python3.6-jupyterlab-0.31.12
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /tmp/nix-build-python3.6-jupyterlab-0.31.12.drv-0 in /nix/store/8inm9adsvgsj649bjs3drcwnx7dzywc9-python3.6-jupyterlab-0.31.12...
wrapping `/nix/store/8inm9adsvgsj649bjs3drcwnx7dzywc9-python3.6-jupyterlab-0.31.12/bin/jlpm'...
wrapping `/nix/store/8inm9adsvgsj649bjs3drcwnx7dzywc9-python3.6-jupyterlab-0.31.12/bin/jupyter-labhub'...
wrapping `/nix/store/8inm9adsvgsj649bjs3drcwnx7dzywc9-python3.6-jupyterlab-0.31.12/bin/jupyter-lab'...
wrapping `/nix/store/8inm9adsvgsj649bjs3drcwnx7dzywc9-python3.6-jupyterlab-0.31.12/bin/jupyter-labextension'...

GrahamcOfBorg · 2018-04-07T18:42:44Z

Success on aarch64-linux (full log)

Attempted: python3Packages.jupyterlab

Partial log (click to expand)

/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
checking for references to /build in /nix/store/w1jg8vyv7yn5hwpyymwl9avn6qawm3xl-python3.6-jupyterlab-0.31.12...
wrapping `/nix/store/w1jg8vyv7yn5hwpyymwl9avn6qawm3xl-python3.6-jupyterlab-0.31.12/bin/jupyter-labhub'...
wrapping `/nix/store/w1jg8vyv7yn5hwpyymwl9avn6qawm3xl-python3.6-jupyterlab-0.31.12/bin/jupyter-labextension'...
wrapping `/nix/store/w1jg8vyv7yn5hwpyymwl9avn6qawm3xl-python3.6-jupyterlab-0.31.12/bin/jupyter-lab'...
wrapping `/nix/store/w1jg8vyv7yn5hwpyymwl9avn6qawm3xl-python3.6-jupyterlab-0.31.12/bin/jlpm'...
/nix/store/w1jg8vyv7yn5hwpyymwl9avn6qawm3xl-python3.6-jupyterlab-0.31.12

dotlambda · 2018-04-07T19:04:18Z

pkgs/development/python-modules/jupyterlab/default.nix

+  ];
+
+  # No tests in archive
+  doCheck = false;


Seems like there are tests in jupyterlab/tests. However, it seems like node is required:

Please install nodejs 5+ and npm before continuing.

dotlambda · 2018-04-07T19:04:34Z

pkgs/development/python-modules/jupyterlab/default.nix

+  meta = with lib; {
+    description = "Jupyter lab environment notebook server extension.";
+    license = with licenses; [ bsd3 ];
+    homepage = "http://jupyter.org/";


There is no consensus on that in nixpkgs. URL literals get transformed into strings so it doesn't make any practical difference. This is unlike path literals which do have a different type.

There is a strong opinion to get rid of the type and use strings instead, but no such (formal) decision has been made. Would it not make sense to keep using the dedicated type for it until decided otherwise? I mean, if people want this they can open an RFC instead of increasing incoherence in the package set.

I agree that we should have the discussion at some point.

nixpkgs is already incoherent so going one way or another doesn't make much difference for new packages. In either case we can write a script that converts existing packages once the above discussion has been resolved.

dotlambda · 2018-04-07T19:04:47Z

pkgs/development/python-modules/jupyterlab_launcher/default.nix

+  meta = with lib; {
+    description = "This package is used to launch an application built using JupyterLab";
+    license = with licenses; [ bsd3 ];
+    homepage = "http://jupyter.org/";


GrahamcOfBorg · 2018-04-07T19:28:11Z

Failure on x86_64-darwin (full log)

Attempted: python3Packages.jupyterlab

Partial log (click to expand)

cannot build derivation '/nix/store/ggvp6ww093vzhianqwklp745903n5pvq-python3.6-nbformat-4.4.0.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/80c22z9cpzl917ld1g442wk3b7z5yq6m-python3.6-pyOpenSSL-17.5.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/fwzn24m965c9w8xz682hqnlycalvfgvz-python3.6-ipykernel-4.8.2.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/8lyzbxr3vbhc7ilkxaggj8cj1y2mnb9s-python3.6-urllib3-1.22.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/mg1d3awm5ybk7qmla8i725da3zhkwcj7-python3.6-nbconvert-5.3.1.drv': 22 dependencies couldn't be built
cannot build derivation '/nix/store/9slg9qzmlc4q7l086c61ahpmiqzs8xzn-python3.6-requests-2.18.4.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/k8w68s7cji4amywz64qigcnmbiwfz5aw-python3.6-notebook-5.4.1.drv': 22 dependencies couldn't be built
cannot build derivation '/nix/store/h4r8i1iwvyhxasx5r2174j98l65c55f9-python3.6-jupyterlab_launcher-0.10.5.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/rn62f6p5zv35qaj1p8yycmbc3bz36y96-python3.6-jupyterlab-0.31.12.drv': 11 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/rn62f6p5zv35qaj1p8yycmbc3bz36y96-python3.6-jupyterlab-0.31.12.drv' failed

veprbl · 2018-04-08T23:07:06Z

I've tested this on macOS. There was a problem with launching jupyter-lab:

[I 18:51:45.038 LabApp] JupyterLab beta preview extension loaded from /nix/store/9wck59c4s6jnf1hiln23mw57qlvd4wj2-python3.6-jupyterlab-0.31.12/lib/python3.6/site-packages/jupyterlab
[I 18:51:45.038 LabApp] JupyterLab application directory is /nix/store/mxrl6zan6h63cwl62bd91bgaghz2d94y-python3-3.6.4/share/jupyter/lab

It can not determine application directory correctly and that breaks the web GUI. There is also missing (seemingly optional) dependency on nodejs.

Would you mind applying a following fix:

--- a/pkgs/development/python-modules/jupyterlab/default.nix
+++ b/pkgs/development/python-modules/jupyterlab/default.nix
@@ -1,4 +1,4 @@
-{ lib, buildPythonPackage, isPy3k, fetchPypi, ipython_genutils, jupyterlab_launcher, notebook }:
+{ lib, buildPythonPackage, isPy3k, fetchPypi, ipython_genutils, jupyterlab_launcher, nodejs, notebook }:
 buildPythonPackage rec {
   pname = "jupyterlab";
   version = "0.31.12";
@@ -12,12 +12,17 @@ buildPythonPackage rec {
   propagatedBuildInputs = [
     ipython_genutils
     jupyterlab_launcher
+    nodejs
     notebook
   ];
 
   # Depends on npm
   doCheck = false;
 
+  makeWrapperArgs = [
+    "--set" "JUPYTERLAB_DIR" "$out/share/jupyter/lab"
+  ];
+
   meta = with lib; {
     description = "Jupyter lab environment notebook server extension.";
     license = with licenses; [ bsd3 ];

Thank you!

veprbl · 2018-04-09T00:11:28Z

Other than that it works very nice!

FRidh · 2018-04-09T13:23:51Z

+  postInstall = ''
+    for prog in "$out"/bin/*; do
+      wrapProgram "$prog" --set JUPYTERLAB_DIR $out/share/jupyter/lab
+    done
+  '';
+

Wrappers are already created by buildPython*. There is a flag for buildPython* to add more things to the wrappers. makeWrapper is also already part of the nativeBuildInputs.

veprbl · 2018-04-09T13:55:57Z

@FRidh
Thank you. I've updated the patch in my original message.

without this option jupyterlab will look into the system python installation directories

zimbatm · 2018-04-09T14:25:52Z

@veprbl thanks for the wrapper. I didn't add nodejs because it breaks the build in sandbox mode:

setting SOURCE_DATE_EPOCH to timestamp 1520372440 of file jupyterlab-0.31.12/PKG-INFO
patching sources
configuring
building
running bdist_wheel
running jsdeps
Installing build dependencies with npm.  This may take a while...
> node /build/jupyterlab-0.31.12/jupyterlab/staging/yarn.js install
yarn install v1.3.2
warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries.
warning Skipping preferred cache folder "/homeless-shelter/.cache/yarn" because it is not writable.
warning Selected the next writable cache folder in the list, will be "/build/.yarn-cache-1000".

FRidh · 2018-04-11T05:49:26Z

If I am correct nodejs is only needed for extensions. We could take that part in a different PR.

zimbatm requested a review from FRidh as a code owner April 7, 2018 18:08

zimbatm added 2 commits April 7, 2018 19:15

pythonPackages.jupyterlab_launcher: init at 0.10.5

636c634

python3Packages.jupyterlab: 0.4.1 -> 0.31.12

878ca5b

zimbatm changed the base branch from master to staging April 7, 2018 18:16

zimbatm force-pushed the jupyterlab-0.31.12 branch from 521fd6a to 878ca5b Compare April 7, 2018 18:16

dotlambda reviewed Apr 7, 2018

View reviewed changes

GrahamcOfBorg added 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 7, 2018

Update default.nix

2e18f16

jupyterlab: fix JUPYTERLAB_DIR lookup

48bc430

without this option jupyterlab will look into the system python installation directories

FRidh mentioned this pull request Apr 11, 2018

pythonPackages.jupyterlab: 0.4.1 -> 0.31.12 #38724

Closed

8 tasks

FRidh merged commit e5c1c3b into NixOS:staging Apr 11, 2018

zimbatm deleted the jupyterlab-0.31.12 branch April 12, 2018 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jupyterlab 0.31.12 #38566

Jupyterlab 0.31.12 #38566

zimbatm commented Apr 7, 2018 •

edited

dotlambda commented Apr 7, 2018

zimbatm commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

dotlambda Apr 7, 2018

dotlambda Apr 7, 2018

zimbatm Apr 7, 2018

FRidh Apr 8, 2018

zimbatm Apr 8, 2018

dotlambda Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

veprbl commented Apr 8, 2018 •

edited

veprbl commented Apr 9, 2018

FRidh commented Apr 9, 2018 •

edited

veprbl commented Apr 9, 2018

zimbatm commented Apr 9, 2018

FRidh commented Apr 11, 2018

Jupyterlab 0.31.12 #38566

Jupyterlab 0.31.12 #38566

Conversation

zimbatm commented Apr 7, 2018 • edited

Motivation for this change

Things done

dotlambda commented Apr 7, 2018

zimbatm commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

GrahamcOfBorg commented Apr 7, 2018

dotlambda Apr 7, 2018

Choose a reason for hiding this comment

dotlambda Apr 7, 2018

Choose a reason for hiding this comment

zimbatm Apr 7, 2018

Choose a reason for hiding this comment

FRidh Apr 8, 2018

Choose a reason for hiding this comment

zimbatm Apr 8, 2018

Choose a reason for hiding this comment

dotlambda Apr 7, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Apr 7, 2018

veprbl commented Apr 8, 2018 • edited

veprbl commented Apr 9, 2018

FRidh commented Apr 9, 2018 • edited

veprbl commented Apr 9, 2018

zimbatm commented Apr 9, 2018

FRidh commented Apr 11, 2018

zimbatm commented Apr 7, 2018 •

edited

veprbl commented Apr 8, 2018 •

edited

FRidh commented Apr 9, 2018 •

edited