Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes horizontal scrolling originating from <code> blocks. (in nixpkgs manual) #205

Merged
merged 1 commit into from Apr 18, 2018

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Apr 7, 2018

See: https://twitter.com/kumbunterland/status/982638331757506567

The <code> blocks are normally expected to have a white-space
property of normal, at least I assume docbook would expect the
default. Bootstrap (2.3) changes it to nowrap, which isn't helpful for
an inline type element.


This is replaced only for the docbook pages. If there is somewhere else <code> elements are used and exhibit the same issue, the rule can be expanded.


Before

20180407143659

After

20180407143707


cc: @grahamc (in case graham's trying to fix it)

See: https://twitter.com/kumbunterland/status/982638331757506567

The `<code>` blocks are normally expected to have a `white-space`
property of `normal`, at least I assume docbook would expect the
default. Bootstrap (2.3) changes it to nowrap, which isn't helpful for
an inline type element.
@samueldr samueldr changed the title Fixes horizontal scrolling originating from <code> blocks. Fixes horizontal scrolling originating from <code> blocks. (in nixpkgs manual) Apr 7, 2018
@grahamc
Copy link
Member

grahamc commented Apr 17, 2018

LGTM

@edolstra edolstra merged commit 3e53706 into NixOS:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants