Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting cargoSha256 to null. #38573

Merged
merged 1 commit into from Apr 8, 2018
Merged

Allow setting cargoSha256 to null. #38573

merged 1 commit into from Apr 8, 2018

Conversation

kevincox
Copy link
Contributor

@kevincox kevincox commented Apr 7, 2018

Setting the hash to null is a convenient way to bypass the hash check
while developing. It looks like the ability to do this was inadvertently
removed while adding vendor directory support.

This still checks that the user is explicitly setting the value but
allows null as a valid option.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kevincox
rust: Allow setting cargoSha256 to null.
4499513 
Setting the hash to null is a convenient way to bypass the hash check
while developing. It looks like the ability to do this was inadvertently
removed while adding vendor directory support.

This still checks that the user is explicitly setting the value but
allows null as a valid option.
@kevincox kevincox requested a review from Mic92 April 7, 2018 21:49
@kevincox kevincox self-assigned this Apr 7, 2018
@Mic92 Mic92 merged commit 5165557 into NixOS:master Apr 8, 2018
@LnL7
Copy link
Member

LnL7 commented Apr 10, 2018

Not sure if I like this, sha256 = null was removed from fetchurl for a reason.

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

Would be different value instead of null better?

@kevincox kevincox deleted the allow-null branch September 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

@kevincox kevincox

Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevincox @LnL7 @Mic92 @GrahamcOfBorg