haskellPackages.blank-canvas: disable tests #38613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peti
requested changes
Apr 8, 2018
The tests require a browser and possibly some manual intervention. See ku-fpg/blank-canvas#73
endgame
force-pushed
the
blank-canvas-dontcheck
branch
from
f984d71
to
c2ce707
Compare
|
Ah, I knew there had to be some tweaks defined somewhere. Note that this fails to build because of something broken in base-compat and base-compat-batteries, but that's broken on current master too. Cherry-picking 2d01bb7 onto release-18.03 does build successfully. |
|
Also: I couldn't find an obvious order to the declarations in that file, so I added at the bottom. LMK if this is incorrect. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The tests require a browser and possibly some manual
intervention. See ku-fpg/blank-canvas#73
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)I had this change building on a branch based on release-18.03 but that had merge conflicts, so this is against master.