Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TEASER_REGEXP to recognize also END_TEASER. Resolves issue #3010 #3011

Merged
merged 1 commit into from Apr 8, 2018
Merged

Update TEASER_REGEXP to recognize also END_TEASER. Resolves issue #3010 #3011

merged 1 commit into from Apr 8, 2018

Conversation

mforbes
Copy link
Contributor

@mforbes mforbes commented Apr 8, 2018

Pull Request Checklist

  • [x ] I’ve read the guidelines for contributing.
  • [x ] I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • [x ] I tested my changes.

Description

Resolves issue #3010.

Kwpolska
Kwpolska approved these changes Apr 8, 2018
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kwpolska Kwpolska merged commit f1f86f6 into getnikola:master Apr 8, 2018
@Kwpolska Kwpolska mentioned this pull request Apr 8, 2018
Closed
@Kwpolska
Copy link
Member

Kwpolska commented Apr 16, 2018 •
edited

This broke my blog, because I used specific [0] and [3] indexes for re.split output. I added a note to the changelog (da4e6b2) with a warning.

Kwpolska added a commit that referenced this pull request Apr 16, 2018
@Kwpolska
Add #3010/#3011 warning
da4e6b2 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@mforbes mforbes deleted the issue_3010 branch April 16, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mforbes @Kwpolska