Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkitgtk: fix non-deterministic build failure #38375

Merged
merged 1 commit into from Apr 3, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 3, 2018

Motivation for this change

The build sometimes fails, due to some necessary header files being generated too late. Building with --cores 1 seems to always trigger the issue. See upstream bug: https://bugs.webkit.org/show_bug.cgi?id=183788

This is a stopgap which simply generates the header files before compilation starts (at postConfigure) and should be removed when the problem is fixed upstream. It might not be ideal, but seems far better than having webkitgtk hold up nixos-unstable, and in the best case causing manual labor restarting hydra jobs.

fixes #37878

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The build sometimes fails, mostly when using a single core. This is a simple
stopgap, see upstream bug: https://bugs.webkit.org/show_bug.cgi?id=183788
@jtojnar jtojnar merged commit 7483972 into NixOS:master Apr 3, 2018
@hedning hedning deleted the webkitgtk-fix-build-failure branch April 3, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webkitgtk-2.20: build broken on hydra
3 participants