Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvfs: fix non-deterministic build failure #38392

Merged
merged 1 commit into from Apr 3, 2018
Merged

gvfs: fix non-deterministic build failure #38392

merged 1 commit into from Apr 3, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 3, 2018

Motivation for this change

Building gvfs with meson causes non-deterministic build failures so switch back to autotools until upstream fixes meson properly. See upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=794549

fixes #38378

Things done

I opted for commenting out meson specific lines and annotating what needs to be deleted/uncommented when switching back to meson.

Tested out with a VM running gnome-shell, and things seemed to work.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 3, 2018

@GrahamcOfBorg build gvfs gnome3.gvfs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gvfs, gnome3.gvfs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@hedning
Copy link
Contributor Author

hedning commented Apr 3, 2018

gnome3.gvfs depends on webkitgtk (through gnome-online-accounts) which isn't cached on master so will probably fail.

@hedning
Copy link
Contributor Author

hedning commented Apr 3, 2018

I did run up a VM (with gnome-shell) with the changes on top of nixos-unstable and things seemed to work at least. Though I just looked through the journal for errors, didn't test any features.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gvfs, gnome3.gvfs

Partial log (click to expand)

/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-copy: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-move: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-monitor-file: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-monitor-dir: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-mkdir: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-mime: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0/bin/gvfs-less: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0...
/nix/store/y1riwlzc5n7d8lihyj85qhrf6f5ighy9-gvfs-1.36.0
/nix/store/r52jm4sy6y4n24yzqjdf92r68xgsb2g4-gvfs-1.36.0

@jtojnar jtojnar merged commit 817c086 into NixOS:master Apr 3, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gvfs, gnome3.gvfs

Partial log (click to expand)

cannot build derivation '/nix/store/nfjkyviyyy9ly6hq1pj5wzy6qxmd491n-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bbqaq71xj30lggbbbf6calm3g7g56c02-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/p6pqwgvm80zsrxbyzpfcyk500f0lfvq5-gst-plugins-bad-1.12.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0hjhsl89xb2yh8m4w00jk2jg1kbqhjzs-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dzg18pavbjmd8fw20csmllyamfp25zgn-geoclue-2.4.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lpz5a3686z1gq4n9qrip73k7s7x6pqzy-webkitgtk-2.20.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/abyss2ccxnhvazr29393vphkhpcq2x11-gnome-online-accounts-3.28.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/pgxv5hsgdra7x3l664bg77rbb5h6vgxa-libgdata-0.17.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/50drf5cck509891y104lds5i0prg9cfv-gvfs-1.36.0.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/50drf5cck509891y104lds5i0prg9cfv-gvfs-1.36.0.drv' failed

@hedning hedning deleted the gvfs-fix branch April 3, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gvfs build fails non-deterministcally on unstable
3 participants
@hedning @jtojnar @GrahamcOfBorg