python3Packages.black: init at 18.4a0 #38386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
requested changes
Apr 3, 2018
| buildPythonPackage rec { | ||
| pname = "black"; | ||
| version = "18.4a0"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
When using buildPythonPackage the name attribute defaults to name = "${pname}-${version}"; so this line can be omitted.
There was a problem hiding this comment.
Good to know. Thanks!
dotlambda
requested changes
Apr 4, 2018
| propagatedBuildInputs = [ attrs click ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "The uncompromising Python code formatter."; |
There was a problem hiding this comment.
|
|
||
| meta = with stdenv.lib; { | ||
| description = "The uncompromising Python code formatter."; | ||
| homepage = "https://github.com/ambv/black"; |
|
@dotlambda made the changes for meta attributes. It can also be used as a python module, for instance here https://github.com/ambv/black/blob/master/vim/plugin/black.vim#L77 |
|
@GrahamcOfBorg build python3.pkgs.black |
|
Success on x86_64-linux (full log) Attempted: python3.pkgs.black Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python3.pkgs.black Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add python code formatter
black: https://github.com/ambv/black.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)