Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnumake42HEAD: remove attribute to fix eval #38389

Merged
merged 1 commit into from Apr 3, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 3, 2018

This probably was intended to be removed as part of
519f0b8 .

EDIT: It was removed in that commit! Well it's there now, perhaps due to a merge? Dunno. Should be removed :).

Noticed borg eval failure in PR's, investigated.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This was removed as part of
519f0b8
but is still present for whatever reason.

Remove since the file no longer exists.
@dtzWill dtzWill merged commit 08b299a into NixOS:staging Apr 3, 2018
@dtzWill dtzWill deleted the fix/gnumakeHEAD-remove branch April 3, 2018 13:06
@dtzWill dtzWill mentioned this pull request Apr 3, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant