Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc: fix instructions for nox-review usage #38380

Merged

Conversation

andrestylianos
Copy link
Member

Motivation for this change

I was submitting a change and the instructions in the manual for running nox-review did not work and I was uncertain why. Then I realized that the instructions in the template were slightly different, needing quotes after --run so I tried that and it worked. Fixing the manual instructions to match the PR template.

Relevant PR template part:

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

@adisbladis
Copy link
Member

Thank you!

@andrestylianos andrestylianos deleted the fix/nox-review-instructions branch April 3, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants