nbstripout: fix tests #38370

jluttine · 2018-04-03T07:58:10Z

Motivation for this change

Building of nbstripout has failed after the version was bumped to 0.3.1 because:
the test files were missing from the new release tarball. This adds tests by
using the release tarball from GitHub instead of PyPI.

However, these tests fail because of a bug in one test. Thus, a patch is used to
fix the tests.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

jluttine · 2018-04-03T07:59:09Z

Note: The changes only affect the tests, that is, the check phase. The actual application remains untouched. These changes just fix the build of the derivation.

FRidh · 2018-04-04T18:21:36Z

pkgs/applications/version-management/nbstripout/default.nix

+      # Remove this patch once the pull request has been merged and a new
+      # release made.
+      fetchurl {
+        url = "https://github.com/kynan/nbstripout/compare/1056b101a0ecf40d7c8722f95632f8c37c9c7fb4...03e28424fb788dd09a95e99814977b0d0846c0b4.patch";


Maybe the following url instead?
https://github.com/jluttine/nbstripout/commit/03e28424fb788dd09a95e99814977b0d0846c0b4.patch

Building of nbstripout has failed after the version was bumped to 0.3.1 because: the test files were missing from the new release tarball. This adds tests by using the release tarball from GitHub instead of PyPI. However, these tests fail because of a bug in one test. Thus, a patch is used to fix the tests.

Mic92 · 2018-04-08T13:09:17Z

@GrahamcOfBorg build nbstripout

GrahamcOfBorg · 2018-04-08T13:09:59Z

Success on x86_64-linux (full log)

Attempted: nbstripout

Partial log (click to expand)

tests/test-hg.t .                                                        [ 45%]
tests/test-keep-count.t .                                                [ 54%]
tests/test-keep-output-keep-count.t .                                    [ 63%]
tests/test-keep-output.t .                                               [ 72%]
tests/test-metadata.t .                                                  [ 81%]
tests/test-unicode.t .                                                   [ 90%]
tests/test-widgets.t .                                                   [100%]

========================== 11 passed in 7.21 seconds ===========================
/nix/store/paj0i06d87zm35zh84rhk16m2q0m7pmd-nbstripout-0.3.1

GrahamcOfBorg · 2018-04-08T13:11:11Z

Success on aarch64-linux (full log)

Attempted: nbstripout

Partial log (click to expand)

tests/test-hg.t .                                                        [ 45%]
tests/test-keep-count.t .                                                [ 54%]
tests/test-keep-output-keep-count.t .                                    [ 63%]
tests/test-keep-output.t .                                               [ 72%]
tests/test-metadata.t .                                                  [ 81%]
tests/test-unicode.t .                                                   [ 90%]
tests/test-widgets.t .                                                   [100%]

========================== 11 passed in 48.16 seconds ==========================
/nix/store/061ja6v1daszrpij7q6prgcc65g1i7nb-nbstripout-0.3.1

GrahamcOfBorg · 2018-04-08T13:12:14Z

Success on x86_64-darwin (full log)

Attempted: nbstripout

Partial log (click to expand)

tests/test-hg.t .                                                        [ 45%]
tests/test-keep-count.t .                                                [ 54%]
tests/test-keep-output-keep-count.t .                                    [ 63%]
tests/test-keep-output.t .                                               [ 72%]
tests/test-metadata.t .                                                  [ 81%]
tests/test-unicode.t .                                                   [ 90%]
tests/test-widgets.t .                                                   [100%]

========================== 11 passed in 11.56 seconds ==========================
/nix/store/kbasnza4zjns6b6bffaykpk51g90q9a6-nbstripout-0.3.1

Mic92 · 2018-04-08T13:19:15Z

Is a backport required here?

jluttine · 2018-04-09T07:48:01Z

Hmm.. Which branch does that mean? If it builds ok, no need to backport. If it fails and this fixes, then I'd backport. But what is the branch it would be backported to? nixos-18.03?

Mic92 · 2018-04-09T10:21:29Z

I was asking if this package also builds on 18.03, in which case I would backport this package.

jluttine · 2018-04-09T17:53:37Z

It seems that on 18.03, nbstripout is still an older version which builds fine. So there is no need to backport this if the upgrade from 0.3.0 to 0.3.1 isn't backported either.

Release: https://github.com/quarkusio/quarkus/releases/tag/3.2.11.Final Complete changelog NixOS#35659 - Fix File handling as a JAX-RS body parameter NixOS#37153 - Bump smallrye-jwt version to 4.4.0 NixOS#38233 - Bump resteasy.version from 6.2.6.Final to 6.2.7.Final NixOS#38236 - Adding a decorator causes bytecode error NixOS#38362 - Register JDBC RowSet required bundle NixOS#38370 - Include RowSet properties file in native image NixOS#38429 - Replace {project-name} attribute in document title for downstream NixOS#38430 - Avoid dots in config doc ids as it's causing issues for downstream NixOS#38580 - Make the Forwarded Parser syntax parsing case-insensitive NixOS#38648 - More documentation adjustments for new downstream tooling NixOS#38649 - Use [[anchor]] format consistently NixOS#38748 - Sanitize app.dekorate.io/vcs-url kubernetes annotation NixOS#38755 - Log when a RestEasy Reactive client close method is called NixOS#38785 - ArC: fix interception when some methods return void NixOS#38865 - Update commons-compress version to mitigate CVE-2024-25710

jluttine force-pushed the fix-nbstripout-0.3.1 branch from cef7bd8 to 17565d4 Compare April 3, 2018 08:07

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 3, 2018

FRidh reviewed Apr 4, 2018

View reviewed changes

jluttine force-pushed the fix-nbstripout-0.3.1 branch from 17565d4 to caf8794 Compare April 5, 2018 07:02

Mic92 merged commit 2c36472 into NixOS:master Apr 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nbstripout: fix tests #38370

nbstripout: fix tests #38370

jluttine commented Apr 3, 2018

jluttine commented Apr 3, 2018

FRidh Apr 4, 2018

jluttine Apr 5, 2018

Mic92 commented Apr 8, 2018

GrahamcOfBorg commented Apr 8, 2018

GrahamcOfBorg commented Apr 8, 2018

GrahamcOfBorg commented Apr 8, 2018

Mic92 commented Apr 8, 2018

jluttine commented Apr 9, 2018

Mic92 commented Apr 9, 2018

jluttine commented Apr 9, 2018

nbstripout: fix tests #38370

nbstripout: fix tests #38370

Conversation

jluttine commented Apr 3, 2018

Motivation for this change

Things done

jluttine commented Apr 3, 2018

FRidh Apr 4, 2018

Choose a reason for hiding this comment

jluttine Apr 5, 2018

Choose a reason for hiding this comment

Mic92 commented Apr 8, 2018

GrahamcOfBorg commented Apr 8, 2018

GrahamcOfBorg commented Apr 8, 2018

GrahamcOfBorg commented Apr 8, 2018

Mic92 commented Apr 8, 2018

jluttine commented Apr 9, 2018

Mic92 commented Apr 9, 2018

jluttine commented Apr 9, 2018