Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocamlify: fix build with OCaml 4.06 #38373

Merged
merged 1 commit into from Apr 8, 2018
Merged

ocamlPackages.ocamlify: fix build with OCaml 4.06 #38373

merged 1 commit into from Apr 8, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 3, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

@GrahamcOfBorg build ocamlPackages.ocamlify

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.ocamlify

Partial log (click to expand)

/nix/store/2qk3hpwwl6fkybsn7d4nnc9ij9120p57-ocaml-4.05.0/bin/ocamlopt.opt unix.cmxa -I /nix/store/w1lqvm6jbg59bk09hw5m83c4zngdaska-ocamlbuild-0.11.0/lib/ocaml/4.05.0/site-lib/ocamlbuild /nix/store/w1lqvm6jbg59bk09hw5m83c4zngdaska-ocamlbuild-0.11.0/lib/ocaml/4.05.0/site-lib/ocamlbuild/ocamlbuildlib.cmxa myocamlbuild.ml /nix/store/w1lqvm6jbg59bk09hw5m83c4zngdaska-ocamlbuild-0.11.0/lib/ocaml/4.05.0/site-lib/ocamlbuild/ocamlbuild.cmx -o myocamlbuild
ocamlfind ocamldep -modules src/ocamlify.ml > src/ocamlify.ml.depends
ocamlfind ocamlc -c -I src -o src/ocamlify.cmo src/ocamlify.ml
ocamlfind ocamlopt -c -I src -o src/ocamlify.cmx src/ocamlify.ml
ocamlfind ocamlopt -linkpkg -I src src/ocamlify.cmx -o src/ocamlify.native
W: Cannot get variable ext_objW: Cannot get variable ext_libW: Cannot get variable ext_dll@nix { "action": "setPhase", "phase": "installPhase" }
installing
post-installation fixup
patching script interpreter paths in /nix/store/hxdqhrl802v2k8i55xri92hsgfk084ad-ocamlify-0.0.2
/nix/store/hxdqhrl802v2k8i55xri92hsgfk084ad-ocamlify-0.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.ocamlify

Partial log (click to expand)

ocamlfind ocamlopt -c -I src -o src/ocamlify.cmx src/ocamlify.ml
ocamlfind ocamlopt -linkpkg -I src src/ocamlify.cmx -o src/ocamlify.native
W: Cannot get variable ext_objW: Cannot get variable ext_libW: Cannot get variable ext_dll@nix { "action": "setPhase", "phase": "installPhase" }
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ibr3mbqd3lj4ps53za2y1n2fv5a7hri7-ocamlify-0.0.2
shrinking /nix/store/ibr3mbqd3lj4ps53za2y1n2fv5a7hri7-ocamlify-0.0.2/bin/ocamlify
patching script interpreter paths in /nix/store/ibr3mbqd3lj4ps53za2y1n2fv5a7hri7-ocamlify-0.0.2
checking for references to /build in /nix/store/ibr3mbqd3lj4ps53za2y1n2fv5a7hri7-ocamlify-0.0.2...
/nix/store/ibr3mbqd3lj4ps53za2y1n2fv5a7hri7-ocamlify-0.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages.ocamlify

Partial log (click to expand)

ocamlfind ocamlopt -c -I src -o src/ocamlify.cmx src/ocamlify.ml
ocamlfind ocamlopt -linkpkg -I src src/ocamlify.cmx -o src/ocamlify.native
W: Cannot get variable ext_objW: Cannot get variable ext_libW: Cannot get variable ext_dll@nix { "action": "setPhase", "phase": "installPhase" }
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/85dzln3xiccng548ax7glwk7n3ip0qd9-ocamlify-0.0.2
shrinking /nix/store/85dzln3xiccng548ax7glwk7n3ip0qd9-ocamlify-0.0.2/bin/ocamlify
patching script interpreter paths in /nix/store/85dzln3xiccng548ax7glwk7n3ip0qd9-ocamlify-0.0.2
checking for references to /build in /nix/store/85dzln3xiccng548ax7glwk7n3ip0qd9-ocamlify-0.0.2...
/nix/store/85dzln3xiccng548ax7glwk7n3ip0qd9-ocamlify-0.0.2

@Mic92 Mic92 merged commit b897bf4 into NixOS:master Apr 8, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

is a backport required here?

@vbgl vbgl deleted the ocamlify branch April 8, 2018 17:33
@vbgl
Copy link
Contributor Author

vbgl commented Apr 8, 2018

What are the rule for back-porting? There is no security issue there…

@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018 •
edited

@vbgl we backport patch releases (0.0.1 -> 0.0.2), bug/build fixes and security updates.
Optionally also new packages, that don't break anything.
If the change here also fixes the build on stable, it should be back ported.

@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

Preferable this should be decided by the maintainer making the change, as they have the best idea, what the consequences of the change are.

@vbgl
Copy link
Contributor Author

vbgl commented Apr 9, 2018

Thanks for the clarification. Then it might be back-ported since 1. it does not break anything (AFAICT); and 2. it may benefit users using OCaml 4.06 on released channels (are there any such users? I don’t know).

@yorickvP yorickvP mentioned this pull request Feb 19, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @GrahamcOfBorg