Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-pin: init at 0.1.2 #38374

Merged
merged 1 commit into from Apr 9, 2018
Merged

nix-pin: init at 0.1.2 #38374

merged 1 commit into from Apr 9, 2018

Conversation

timbertson
Copy link
Contributor

@timbertson timbertson commented Apr 3, 2018 •
edited

Motivation for this change

Introduces nix pin (https://github.com/timbertson/nix-pin) at 0.1.2.

Nix pin is a development utility for "pinning" individual nixpkgs derivations to in-development versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timbertson timbertson changed the title nix-pin: init at 0.1.1 nix-pin: init at 0.1.2 Apr 5, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 8, 2018

@GrahamcOfBorg build nix-pin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nix-pin

Partial log (click to expand)

Cannot nix-instantiate `nix-pin' because:
�[31;1merror:�[0m attribute 'nix-pin' in selection path 'nix-pin' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: nix-pin

Partial log (click to expand)

Cannot nix-instantiate `nix-pin' because:
�[31;1merror:�[0m attribute 'nix-pin' in selection path 'nix-pin' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nix-pin

Partial log (click to expand)

Cannot nix-instantiate `nix-pin' because:
�[31;1merror:�[0m attribute 'nix-pin' in selection path 'nix-pin' not found

Mic92
Mic92 reviewed Apr 8, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -20509,6 +20509,8 @@ with pkgs;

nix-index = callPackage ../tools/package-management/nix-index { };

nixPin = callPackage ../tools/package-management/nix-pin { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not nix-pin like the project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought there was a preference for camelCase. After digging a bit I realise the opposite is true, so I've now amended the commit to make it nix-pin.

@timbertson
Copy link
Contributor Author

@GrahamcOfBorg build nix-pin

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Apr 9, 2018

@GrahamcOfBorg build nix-pin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-pin

Partial log (click to expand)

building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l4g7wm0riakfcghng5h7q4qmkbni103a-nix-pin-0.1.2
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/l4g7wm0riakfcghng5h7q4qmkbni103a-nix-pin-0.1.2/bin
patching script interpreter paths in /nix/store/l4g7wm0riakfcghng5h7q4qmkbni103a-nix-pin-0.1.2
/nix/store/l4g7wm0riakfcghng5h7q4qmkbni103a-nix-pin-0.1.2/bin/nix-pin: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/azw9ys2m2fpfzf730xjcxja890gpyp58-python3-3.6.4/bin/python3"
checking for references to /build in /nix/store/l4g7wm0riakfcghng5h7q4qmkbni103a-nix-pin-0.1.2...
/nix/store/l4g7wm0riakfcghng5h7q4qmkbni103a-nix-pin-0.1.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-pin

Partial log (click to expand)

building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q1win1q16m0c3gncal2g17fpf5hyrrp0-nix-pin-0.1.2
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q1win1q16m0c3gncal2g17fpf5hyrrp0-nix-pin-0.1.2/bin
patching script interpreter paths in /nix/store/q1win1q16m0c3gncal2g17fpf5hyrrp0-nix-pin-0.1.2
/nix/store/q1win1q16m0c3gncal2g17fpf5hyrrp0-nix-pin-0.1.2/bin/nix-pin: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/dm6n8imydr8bdhr4j6l6wwfx8h99h781-python3-3.6.4/bin/python3"
checking for references to /build in /nix/store/q1win1q16m0c3gncal2g17fpf5hyrrp0-nix-pin-0.1.2...
/nix/store/q1win1q16m0c3gncal2g17fpf5hyrrp0-nix-pin-0.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nix-pin

Partial log (click to expand)

configuring
no configure script, doing nothing
building
installing
post-installation fixup
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bkzlhda2w6kp5ab7ffppilxpv8dj89k2-nix-pin-0.1.2/bin
patching script interpreter paths in /nix/store/bkzlhda2w6kp5ab7ffppilxpv8dj89k2-nix-pin-0.1.2
/nix/store/bkzlhda2w6kp5ab7ffppilxpv8dj89k2-nix-pin-0.1.2/bin/nix-pin: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/mxrl6zan6h63cwl62bd91bgaghz2d94y-python3-3.6.4/bin/python3"
/nix/store/bkzlhda2w6kp5ab7ffppilxpv8dj89k2-nix-pin-0.1.2

@Mic92 Mic92 merged commit 9392b10 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timbertson @Mic92 @GrahamcOfBorg