Fix gnome-shell-extensions-3.28.0 #38390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: GNOME
jtojnar
reviewed
Apr 3, 2018
|
|
||
| if [ -f $schema ]; then | ||
| mkdir $f/schemas | ||
| cp $schema $f/schemas; |
| @@ -23,7 +23,7 @@ in stdenv.mkDerivation rec { | |||
| libnotify gnome3.gnome-shell python3Packages.pygobject3 | |||
| libsoup gnome3.gnome-settings-daemon gnome3.nautilus | |||
| gnome3.mutter gnome3.gnome-desktop gobjectIntrospection | |||
| gnome3.nautilus | |||
| gnome3.nautilus gnome3.gnome-shell-extensions | |||
There was a problem hiding this comment.
Could you add comment that it is needed for schemas from the theme extension?
This makes it possible to use the `user-theme` extension.
hedning
force-pushed
the
gnome-shell-extensions
branch
from
558a606
to
7f3e2f6
Compare
jtojnar
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes three problems that surfaced when upgrading to gnome 3.28
The new meson build doesn't compile the schema files.
The
apps-menuextension broke bygnome-shellno longer depending ongnome-menus.Lastly
gnome-tweaksdidn't find the necessary files to let users change themes when theuser-themeextension was enabled.cc @jtojnar
fixes #38377
Things done
Light testing of the changes in a VM on top of
nixos-unstable.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)