Sublime dev #38383
Merged
Sublime dev #38383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quoting myself from the original PR:
|
|
@jtojnar done. |
|
Great, thanks. Although I still do not like the argument duplication very much. Could you do something like, for example, Firefox does? |
|
@jtojnar done. |
jtojnar
approved these changes
Apr 3, 2018
zimbatm
reviewed
Apr 3, 2018
| x32sha256 = "0dgpx4wij2m77f478p746qadavab172166bghxmj7fb61nvw9v5i"; | ||
| x64sha256 = "06b554d2cvpxc976rvh89ix3kqc7klnngvk070xrs8wbyb221qcw"; | ||
| } {}; | ||
| } |
There was a problem hiding this comment.
the rec keywords in this file don't seem to be necessary. rec is useful to re-export keys of the current attrset as similarly-named variables into the local scope.
There was a problem hiding this comment.
done: 45e72ed
zimbatm
approved these changes
Apr 3, 2018
|
@MasseGuillaume The sublime(2) attribute was removed by this PR. I suppose this was by accident. |
|
Right, sorry, fixed in 8e18b7c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurecting: #26718