-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monthly update for Gambit and Gerbil #38365
Conversation
Hm, seems to be a merge conflict. |
description = "Optimizing Scheme to C compiler"; | ||
homepage = "http://gambitscheme.org"; | ||
license = stdenv.lib.licenses.lgpl2; | ||
platforms = stdenv.lib.platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use stdenv.lib.platforms.unix
to also consider darwin
description = "Gerbil Scheme"; | ||
homepage = "https://github.com/vyzo/gerbil"; | ||
license = stdenv.lib.licenses.lgpl2; | ||
platforms = stdenv.lib.platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use stdenv.lib.platforms.unix
to also consider darwin
@marsam does this mean that you have tested it on Darwin, or does that mean you want to use ofborg for such a test? (Given there is a merge conflict here and that the platform change is not likely to be a merge conflict, feel free to ping me if you open a PR for such a platform set change) |
I will merge and update. Is it alright to use stdenv.lib.platforms.unix rather than stdenv.lib.platforms.linux if I didn't try on Darwin? Is there Windows support? Gambit runs on Windows, though I haven't tried my recipe there either. Are there test machines I can use somewhere? Or test machines as part of the CI infrastructure? |
OK, so I resolved the merge conflict, which was just this linux vs unix issue. I'm glad to use unix. I haven't tested on anything but Linux, so expect some breakage or bitrot on some unix target somehow, even though the code is portable and has been known to run on OpenBSD, macOS, Windows, etc. |
@GrahamcOfBorg build gambit gambit-unstable garbil gerbil-unstable |
Failure on x86_64-darwin (full log) Attempted: gambit, gambit-unstable, gerbil-unstable The following builds were skipped because they don't evaluate on x86_64-darwin: garbil Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: gambit, gambit-unstable, gerbil-unstable The following builds were skipped because they don't evaluate on x86_64-linux: garbil Partial log (click to expand)
|
@grahamc do all the macOS builders all use 1800 second timeout, is there only one, or did I get unlucky? |
Failure on aarch64-linux (full log) Attempted: gambit, gambit-unstable, gerbil-unstable The following builds were skipped because they don't evaluate on aarch64-linux: garbil Partial log (click to expand)
|
I guess we'll see if Hydra complains… |
Motivation for this change
Monthly update with regular progress on Gerbil and a few bug fixes for Gambit.
Introduce gambit-unstable and gerbil-unstable with date-based names that fit the nixpkgs convention.
Have gerbil-unstable use gambit-unstable.
Make gambit (stable, default) exactly match upstream 4.8.9.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)