Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly update for Gambit and Gerbil #38365

Merged
merged 2 commits into from Apr 4, 2018
Merged

Conversation

fare
Copy link
Contributor

@fare fare commented Apr 3, 2018

Motivation for this change

Monthly update with regular progress on Gerbil and a few bug fixes for Gambit.

Introduce gambit-unstable and gerbil-unstable with date-based names that fit the nixpkgs convention.

Have gerbil-unstable use gambit-unstable.

Make gambit (stable, default) exactly match upstream 4.8.9.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Apr 3, 2018

Hm, seems to be a merge conflict.

description = "Optimizing Scheme to C compiler";
homepage = "http://gambitscheme.org";
license = stdenv.lib.licenses.lgpl2;
platforms = stdenv.lib.platforms.linux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use stdenv.lib.platforms.unix to also consider darwin

description = "Gerbil Scheme";
homepage = "https://github.com/vyzo/gerbil";
license = stdenv.lib.licenses.lgpl2;
platforms = stdenv.lib.platforms.linux;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use stdenv.lib.platforms.unix to also consider darwin

@7c6f434c
Copy link
Member

7c6f434c commented Apr 4, 2018

@marsam does this mean that you have tested it on Darwin, or does that mean you want to use ofborg for such a test? (Given there is a merge conflict here and that the platform change is not likely to be a merge conflict, feel free to ping me if you open a PR for such a platform set change)

@fare
Copy link
Contributor Author

fare commented Apr 4, 2018

I will merge and update.

Is it alright to use stdenv.lib.platforms.unix rather than stdenv.lib.platforms.linux if I didn't try on Darwin? Is there Windows support? Gambit runs on Windows, though I haven't tried my recipe there either. Are there test machines I can use somewhere? Or test machines as part of the CI infrastructure?

@fare
Copy link
Contributor Author

fare commented Apr 4, 2018

OK, so I resolved the merge conflict, which was just this linux vs unix issue. I'm glad to use unix. I haven't tested on anything but Linux, so expect some breakage or bitrot on some unix target somehow, even though the code is portable and has been known to run on OpenBSD, macOS, Windows, etc.

@7c6f434c
Copy link
Member

7c6f434c commented Apr 4, 2018

@GrahamcOfBorg build gambit gambit-unstable garbil gerbil-unstable

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gambit, gambit-unstable, gerbil-unstable

The following builds were skipped because they don't evaluate on x86_64-darwin: garbil

Partial log (click to expand)

clang -Wno-deprecated-declarations -I"/usr/local/opt/openssl/include"   -Wno-unused -Wno-write-strings -Wdisabled-optimization -O2 -fwrapv -fno-strict-aliasing -fno-math-errno -fmodulo-sched -fomit-frame-pointer -fPIC -fno-common   -I"../include" -c -o "_t-univ-4.o" -I. -DHAVE_CONFIG_H _t-univ-4.c -D___LIBRARY
clang-5.0: warning: optimization flag '-fmodulo-sched' is not supported [-Wignored-optimization-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
clang -Wno-deprecated-declarations -I"/usr/local/opt/openssl/include"   -Wno-unused -Wno-write-strings -Wdisabled-optimization -O2 -fwrapv -fno-strict-aliasing -fno-math-errno -fmodulo-sched -fomit-frame-pointer -fPIC -fno-common   -I"../include" -c -o "_t-univ-4.o" -I. -DHAVE_CONFIG_H _t-univ-4.c -D___LIBRARY
clang-5.0: warning: optimization flag '-fmodulo-sched' is not supported [-Wignored-optimization-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
building of '/nix/store/p4vhkvxvh95c3nhr25258cd14vc0bdby-gambit-4.8.9.drv' timed out after 1800 seconds
building of '/nix/store/9khgd0nzpc9y3h798gkakvrh1fcqfkbl-gambit-unstable-2018-03-26.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/gxakc16fjbz7pifnhqykc54f80aa2rah-gerbil-unstable-2018-04-03.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/9khgd0nzpc9y3h798gkakvrh1fcqfkbl-gambit-unstable-2018-03-26.drv', '/nix/store/gxakc16fjbz7pifnhqykc54f80aa2rah-gerbil-unstable-2018-04-03.drv', '/nix/store/p4vhkvxvh95c3nhr25258cd14vc0bdby-gambit-4.8.9.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gambit, gambit-unstable, gerbil-unstable

The following builds were skipped because they don't evaluate on x86_64-linux: garbil

Partial log (click to expand)

shrinking /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03/lib/gerbil/compiler/optimize-ann__0.o1
shrinking /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03/lib/gerbil/compiler/optimize-ann__rt.o1
shrinking /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03/lib/gerbil/compiler/driver__rt.o1
shrinking /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03/lib/gerbil/core$_expander-runtime___rt.o1
shrinking /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03/lib/gerbil/core$_sugar_$_sugar_1___rt.o1
patching script interpreter paths in /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03
checking for references to /tmp/nix-build-gerbil-unstable-2018-04-03.drv-0 in /nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03...
/nix/store/bgw6s7sb75av0af2fh7xxzsq3zricn2n-gambit-4.8.9
/nix/store/2ax53lahij9pmiwscq1ndc5b4i6mxkwb-gambit-unstable-2018-03-26
/nix/store/38pa6ljzhx3n66br3vss039v9ydqfhl5-gerbil-unstable-2018-04-03

@7c6f434c
Copy link
Member

7c6f434c commented Apr 4, 2018

@grahamc do all the macOS builders all use 1800 second timeout, is there only one, or did I get unlucky?

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gambit, gambit-unstable, gerbil-unstable

The following builds were skipped because they don't evaluate on aarch64-linux: garbil

Partial log (click to expand)

 ___END_M_COD
 ^~~~~~~~~~~~
_io.c:85192:1: warning: PRE disabled: 17258 basic blocks and 75256 registers; increase --param max-gcse-memory above 162363264 [-Wdisabled-optimization]
_io.c:85192:1: warning: const/copy propagation disabled: 17258 basic blocks and 75256 registers; increase --param max-gcse-memory above 162363264 [-Wdisabled-optimization]
_io.c:85192:1: warning: const/copy propagation disabled: 17060 basic blocks and 75530 registers; increase --param max-gcse-memory above 161182880 [-Wdisabled-optimization]
_io.c:85192:1: warning: const/copy propagation disabled: 17060 basic blocks and 75530 registers; increase --param max-gcse-memory above 161182880 [-Wdisabled-optimization]
building of '/nix/store/mxfmk8qkzxzqw6w7csczghj8r8gmnz2k-gambit-4.8.9.drv' timed out after 3600 seconds
building of '/nix/store/nijfpr7nhc1j92k1c4cr892c603gsln1-gambit-unstable-2018-03-26.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/s8ax14qk9n3s588jy8f2r7caxnyggrlx-gerbil-unstable-2018-04-03.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/mxfmk8qkzxzqw6w7csczghj8r8gmnz2k-gambit-4.8.9.drv', '/nix/store/nijfpr7nhc1j92k1c4cr892c603gsln1-gambit-unstable-2018-03-26.drv', '/nix/store/s8ax14qk9n3s588jy8f2r7caxnyggrlx-gerbil-unstable-2018-04-03.drv' failed

@7c6f434c
Copy link
Member

7c6f434c commented Apr 4, 2018

I guess we'll see if Hydra complains…

@7c6f434c 7c6f434c merged commit 31fe962 into NixOS:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants