pythonPackages.pushover: init at 0.3 #37293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: home-assistant Partial log (click to expand)
|
FRidh
approved these changes
Mar 18, 2018
dotlambda
reviewed
Mar 18, 2018
| propagatedBuildInputs = [ requests ]; | ||
|
|
||
| # checks crash | ||
| doCheck = false; |
There was a problem hiding this comment.
Tests could be run using python test.py but they require network access: https://github.com/laprice/pushover/blob/master/test.py
dotlambda
reviewed
Mar 18, 2018
| @@ -12,7 +12,7 @@ buildPythonPackage rec { | |||
|
|
|||
| propagatedBuildInputs = [ requests ]; | |||
|
|
|||
| # checks crash | |||
| # there are no tests | |||
There was a problem hiding this comment.
@Mic92 That's not true: https://github.com/laprice/pushover/blob/master/test.py
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
6.topic: python
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed for home-assistant.
Cc: @FRidh @dotlambda
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)