Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify: 1.0.69.336.g7edcc575-39 -> 1.0.72.117.g6bd7cc73-35 #37273

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

MichielDerhaeg
Copy link
Contributor

Motivation for this change

Sorry for remaking this PR, I moved some branches around and forgot this was still open.
Can't we just merge despite #36991 and #36750, it's the only version that is available.
Without this change, the package will remain broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 17, 2018
@Mic92 Mic92 merged commit 856bbf0 into NixOS:master Mar 17, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 17, 2018

backported to 17.09 and 18.03.

@flokli flokli mentioned this pull request Mar 18, 2018
@MichielDerhaeg MichielDerhaeg deleted the spotify branch July 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants