Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because
{ captures }
are localized they are will be unchangedwhen
->_match
returns. So we are not required to restore themMotivation
Because
$captures
is a hash reference to$self->{ captures }
The code effectively do nothing, eg.
$hashref = $hashref
.Maybe you mean copy by value
$hashref = { %$hashref }
as this is done for$self->stack
:But
{captures}
are localized so this copy by value is not requiredReferences
related to this commit