Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.timepp: init at 2018.03.17 #37306

Merged
merged 1 commit into from Mar 18, 2018
Merged

gnomeExtensions.timepp: init at 2018.03.17 #37306

merged 1 commit into from Mar 18, 2018

Conversation

svsdep
Copy link
Contributor

@svsdep svsdep commented Mar 18, 2018 •
edited

Motivation for this change

I need this extension for my desktop setup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Mar 18, 2018
Mic92
Mic92 reviewed Mar 18, 2018
View reviewed changes
pkgs/desktops/gnome-3/extensions/timepp/default.nix Outdated

stdenv.mkDerivation rec {
name = "gnome-shell-extension-timepp-${version}";
version = "440cf85dc68d9e6ba876793f13910ee6239622cf";
Copy link
Member

@Mic92 Mic92 Mar 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please you the date of the commit instead of a commit hash as version number. Dates are more human-readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@svsdep svsdep changed the title gnomeExtensions.timepp: init at 440cf85dc68d9e6ba876793f13910ee6239622cf gnomeExtensions.timepp: init at 2018.03.17 Mar 18, 2018
@Mic92 Mic92 merged commit 5ca797c into NixOS:master Mar 18, 2018
@svsdep svsdep deleted the gnome-3-timepp branch March 18, 2018 09:37
@AndrewKvalheim AndrewKvalheim mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svsdep @Mic92 @GrahamcOfBorg