Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: fixed example config for networking.interfaces #37272

Merged
merged 1 commit into from Mar 18, 2018
Merged

nixos/manual: fixed example config for networking.interfaces #37272

merged 1 commit into from Mar 18, 2018

Conversation

erictapen
Copy link
Member

The former example gave a "value is a list while a set was expected" error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@erictapen
nixos/manual: fixed example config for networking.interfaces
d69e0d9 
The former example gave a "value is a list while a set was expected" error.
@srhb
Copy link
Contributor

srhb commented Mar 18, 2018

Thanks!

@srhb srhb merged commit 45241c5 into NixOS:master Mar 18, 2018
@erictapen erictapen deleted the manual-networking branch March 19, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @srhb @GrahamcOfBorg