Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python fixes #37250

Merged
merged 25 commits into from Mar 18, 2018
Merged

Python fixes #37250

merged 25 commits into from Mar 18, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

#36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner March 17, 2018 14:59
@dotlambda dotlambda mentioned this pull request Mar 17, 2018
Closed
@dotlambda
Copy link
Member Author

@FRidh Should this go into staging or can I merge into master?

@dotlambda
Copy link
Member Author

/cc klaus maintainer @matthiasbeyer

pythonPackages.odo: mark as broken
0b6a2b2 
Odo is incompatible with Networkx 2.
See blaze/odo#601.
@FRidh
Copy link
Member

FRidh commented Mar 18, 2018

@dotlambda these are all minor packages, also judging from the @GrahamcOfBorg output, so therefore master.

matthiasbeyer
matthiasbeyer approved these changes Mar 18, 2018
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve for the "klaus" package, did not review others.

I would like to see someone else maintaining it, though. I can maintain it until may, so I don't mind merging this with me as maintainer, but from may to 2019 I cannot be maintainer of any nixpkg, so if someone would step up as maintainer, I wouldn't mind! 😄

@dotlambda
Copy link
Member Author

@matthiasbeyer I think https://github.com/ryantm/nix-update will take care of maintaining :D

@dotlambda dotlambda merged commit 3d183c1 into NixOS:master Mar 18, 2018
@dotlambda dotlambda deleted the python-fixes branch March 18, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @FRidh @matthiasbeyer @GrahamcOfBorg