Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: fix usage over ssh #37308

Merged
merged 1 commit into from Mar 18, 2018
Merged

gitea: fix usage over ssh #37308

merged 1 commit into from Mar 18, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Mar 18, 2018

Motivation for this change

Using gitea over ssh had two isses:

  1. No shell was set for the user
  2. Gitea tried to write logs to
    /nix/store/x83q12kyd9gw1pay036dxz2dq0apf17h-gitea-1.3.2-bin/log when
    serving the ssh usage.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @disassembler

@etu
gitea: fix usage over ssh
fa76c9a 
Using gitea over ssh had two isses:
 1. No shell was set for the user
 2. Gitea tried to write logs to
 /nix/store/x83q12kyd9gw1pay036dxz2dq0apf17h-gitea-1.3.2-bin/log when
 serving the ssh usage.
@Mic92 Mic92 merged commit a8b81d1 into NixOS:master Mar 18, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2018 •
edited

also ported to 18.03.

@etu etu deleted the gitea-working-git-over-ssh branch March 18, 2018 09:42
@etu
Copy link
Contributor Author

etu commented Mar 18, 2018

@Mic92 Thanks 👍

@disassembler
Copy link
Member

disassembler commented Mar 19, 2018 •
edited

Ironically I had the 2nd as a commit in my fork of nixpkgs and seriously thought about appending it to your pull request I merged earlier this week! Thanks for all the contributions and testing to find issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @Mic92 @disassembler @GrahamcOfBorg