Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gosmore: fix build with gcc7 #37285

Merged
merged 1 commit into from Mar 18, 2018
Merged

gosmore: fix build with gcc7 #37285

merged 1 commit into from Mar 18, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

fix build with gcc7: https://hydra.nixos.org/build/70739382
cc ZHF #36453
cc @7c6f434c maintainer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c merged commit 3a9bdaa into NixOS:master Mar 18, 2018
@symphorien
Copy link
Member Author

Thanks. Could it be cherry-picked to 18.03 as well ?

@xeji xeji mentioned this pull request Mar 27, 2018
Closed
@symphorien symphorien deleted the gosmore branch May 18, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @7c6f434c @GrahamcOfBorg