Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiveopteryx: fix build w/gcc7 #37264

Merged
merged 1 commit into from Mar 18, 2018
Merged

archiveopteryx: fix build w/gcc7 #37264

merged 1 commit into from Mar 18, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 17, 2018

Motivation for this change

Didn't build with gcc7.

cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: archiveopteryx

Partial log (click to expand)

shrinking /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/bin/recorder
shrinking /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/lib/installer
gzipping man pages under /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/lib  /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/bin
patching script interpreter paths in /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0
/nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/lib/contrib/rrdglue: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
/nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0/lib/archiveopteryx: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0...
/nix/store/x9x2rb9sr56sy4kvaz0qi5bqmjh29l47-archiveopteryx-3.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: archiveopteryx

Partial log (click to expand)

shrinking /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/bin/aoxexport
shrinking /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/lib/installer
gzipping man pages under /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/lib  /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/bin
patching script interpreter paths in /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0
/nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/lib/contrib/rrdglue: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0/lib/archiveopteryx: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0...
/nix/store/k4qsdpq9wi0ifzx0bz0cmr9s1af3mrbc-archiveopteryx-3.2.0

vcunat added a commit that referenced this pull request Mar 18, 2018
@vcunat
Merge #37264: archiveopteryx: fix build w/gcc7
617d73f 
(cherry picked from commit 214016c)
@vcunat vcunat merged commit add347c into NixOS:master Mar 18, 2018
vcunat added a commit that referenced this pull request Mar 18, 2018
@vcunat
Merge #37264: archiveopteryx: fix build w/gcc7
214016c
@xeji xeji deleted the p/archiveopteryx branch March 18, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @vcunat