appres: 1.0.4 -> 1.0.5 #37265
Closed
appres: 1.0.4 -> 1.0.5 #37265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done: - built on NixOS - Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.) - found 1.0.5 with grep in /nix/store/9lmxba58f0s416l1bcqb143m3ncca0g5-appres-1.0.5 - directory tree listing: https://gist.github.com/ef5ccc686f828057356edf379cf6a601
infinisil
requested changes
Mar 24, 2018
| @@ -140,10 +140,10 @@ let | |||
| }) // {inherit ;}; | |||
|
|
|||
| encodings = (mkDerivation "encodings" { | |||
| name = "encodings-1.0.4"; | |||
There was a problem hiding this comment.
You should update your script to handle this case here..
It updated all 1.0.4 versions in this file to 1.0.5 versions, which may not exist and even if they did, the hash isn't changed, so it would probably still build..
There was a problem hiding this comment.
Yes. I fixed this issue recently by making it give up when a file has multiple fetchers in it. That will have to do until I figured out how to make it smarter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done: