nixos/dnsdist: init module #37289
Merged
nixos/dnsdist: init module #37289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No attempt on x86_64-darwin The following builds were skipped because they don't evaluate on x86_64-darwin: dnsdist, powerdns No log is available. |
|
I also think this should go into 18.03 since the recursor options have been removed from authoritative powerdns server. |
|
Success on aarch64-linux (full log) Attempted: dnsdist The following builds were skipped because they don't evaluate on aarch64-linux: powerdns Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: dnsdist, powerdns Partial log (click to expand)
|
Mic92
reviewed
Mar 18, 2018
| PrivateTmp=true; | ||
| PrivateDevices=true; | ||
| CapabilityBoundingSet="CAP_NET_BIND_SERVICE CAP_SETGID CAP_SETUID"; | ||
| ExecStart = "${pkgs.dnsdist}/bin/dnsdist --uid=nobody --gid=nogroup --supervised --disable-syslog --config ${configFile}"; |
There was a problem hiding this comment.
Can you look into systemd's DynamicUser instead of nobody? If we run every service as nobody the user separation is undermined.
|
I'll test that and update pr tomorrow. Should I make that suggestion for
upstream unit as well? They don't set uid or gid in upstream.
Thanks,
Sam
…On Sun, Mar 18, 2018, 04:42 Jörg Thalheim ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nixos/modules/services/networking/dnsdist.nix
<#37289 (comment)>:
> + };
+
+ config = mkIf config.services.dnsdist.enable {
+ systemd.services.dnsdist = {
+ description = "dnsdist load balancer";
+ wantedBy = [ "multi-user.target" ];
+ after = ["network.target"];
+
+ serviceConfig = {
+ Restart="on-failure";
+ RestartSec="1";
+ StartLimitInterval="0";
+ PrivateTmp=true;
+ PrivateDevices=true;
+ CapabilityBoundingSet="CAP_NET_BIND_SERVICE CAP_SETGID CAP_SETUID";
+ ExecStart = "${pkgs.dnsdist}/bin/dnsdist --uid=nobody --gid=nogroup --supervised --disable-syslog --config ${configFile}";
Can you look into systemd's DynamicUser instead of nobody? If we run
every service as nobody the user separation is undermined.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37289 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnvxQqKpcAB25bZSSrjvmhfmfjYn5Yvks5tfh4JgaJpZM4SvBUg>
.
|
|
@disassembler yes. |
|
Still interested in this? A dnsdist expression was merged in #38658, though without a service. |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: powerdns Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: powerdns Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: powerdns Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds dnsdist which is now the recommended way to run an authoritative and recursor DNS service using powerdns if you need ACL's.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)