plex: use buildFHSUserEnv #38767

lukateras · 2018-04-11T12:34:00Z

Fixes #25502. NixOS module is not tested yet.

mkaito · 2018-05-02T12:03:07Z

Haven't been able to get this to run. Something about chdir path not found in the logs. Would be nice if it said what path that is. Guess I'll have to strace this thing to find out.

colemickens · 2018-05-30T21:36:00Z

Sorry, I had failed to cherry-pick both commits properly. When I do so, I'm back to basically getting zero useful output from the journal. This is literally all I get now:

May 30 14:35:03 chimera systemd[1]: Starting Plex Media Server...
May 30 14:35:03 chimera plex-pre-start[28065]: Preparing plugin directory.
May 30 14:35:03 chimera plex-pre-start[28065]: Removing old symlinks.
May 30 14:35:03 chimera plex-pre-start[28065]: Symlinking plugins.
May 30 14:35:03 chimera systemd[1]: Started Plex Media Server.
May 30 14:35:04 chimera systemd[1]: plex.service: Main process exited, code=exited, status=255/n/a
May 30 14:35:04 chimera systemd[1]: plex.service: Failed with result 'exit-code'.
May 30 14:35:04 chimera systemd[1]: plex.service: Service hold-off time over, scheduling restart.
May 30 14:35:04 chimera systemd[1]: plex.service: Scheduled restart job, restart counter is at 5.
May 30 14:35:04 chimera systemd[1]: Stopped Plex Media Server.
May 30 14:35:04 chimera systemd[1]: plex.service: Start request repeated too quickly.
May 30 14:35:04 chimera systemd[1]: plex.service: Failed with result 'exit-code'.

colemickens · 2018-06-12T01:37:07Z

With this PR applied, if I run ExecStartPre and then ExecStart, the server seems to startup, but it doesn't have access to the existing data, as its running me through a first time install. Maybe this is due to me executing the commands one after another in a regular shell, rather than how systemd runs them.

Either way, I'm not sure how to proceed debugging the systemd unit that is emitted for plex to get it to start properly.

colemickens · 2018-06-18T20:33:46Z

This is now working great for me. Thank you very much!

colemickens · 2018-06-19T05:30:45Z

pkgs/servers/plex/default.nix

-  vsnHash = plexpkg.vsnHash;
-  sha256 = plexpkg.sha256;
+  name = "plexmediaserver-${version}";
+  version = "1.9.6.4429-23901a099";


Only thing I noticed, this is a major step back in terms of version.

The latest publicly available release works fine.

diff --git a/pkgs/servers/plex/default.nix b/pkgs/servers/plex/default.nix index 4ce1410e46a..247eb7ad737 100644 --- a/pkgs/servers/plex/default.nix +++ b/pkgs/servers/plex/default.nix @@ -2,11 +2,11 @@ let name = "plexmediaserver-${version}"; - version = "1.9.6.4429-23901a099"; + version = "1.13.2.5154-fd05be322"; src = fetchurl { url = "https://downloads.plex.tv/plex-media-server/${version}/${name}.x86_64.rpm"; - sha256 = "0bmqf8b2d9h2h5q3n4ahs8y6a9aihj63rch7wd82rcr1l9xnqk9d"; + sha256 = "09hy9xhhv17jbzplyls13xrzaxndlc278amp6k3w8q4j6wpsi6np"; };

mkaito · 2018-06-19T12:30:27Z

Updated package.

Rebased from nixos-unstable-small and squashed commits for cherry picking.

Tested on my local setup and works for me.

GrahamcOfBorg · 2018-06-19T13:20:50Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: plex

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-19T13:20:56Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: plex

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-19T13:21:09Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: plex

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

mkaito

Been using for a few days. Have encountered no issues.

lukateras · 2018-06-20T20:15:29Z

Will merge when I address reverse compatibility issues (this works much better, but not reverse compatible).

mkaito · 2018-06-20T21:16:14Z

What's not compatible? Did you move the database?

colemickens · 2018-06-20T22:31:29Z

(My existing media database just worked with the commit I pulled, anyway.)

mkaito · 2018-06-21T09:46:50Z

The only problem I've found is the preStart script of the version in master will screw with a library created with the PR version. So don't "downgrade", I guess.

LnL7 · 2018-06-21T10:57:48Z

pkgs/servers/plex/default.nix

-      patchelf --set-interpreter "${glibc.out}/lib/ld-linux-x86-64.so.2" "$out/usr/lib/plexmediaserver/$bin"
-      patchelf --set-rpath "$out/usr/lib/plexmediaserver" "$out/usr/lib/plexmediaserver/$bin"
-    done
+buildFHSUserEnv {


Why use buildFHSUserEnv instead of patching a few binaries, doesn't this make accessing media way more complicated then it should be?

That makes Plex plugins usable.

I believe that FHS containers are better for pre-built binaries than patchelf because that means original binary doesn't have to be refetched on every major rebuild. That's especially important when there are redistribution restrictions on the binary. Also, that allows programs to download additional executables at run time.

Also that doesn't break self-checksumming executables. Generally, this is less prone to break over time.

More importantly, though, is that it seems like a more proper separation of concerns.

Because you can't patch binaries that Plex downloads at runtime.

colemickens · 2018-07-10T05:48:07Z

Gentle ping. Is there anything I can do to help this along?

colemickens · 2018-08-19T16:50:27Z

Ping again.

colemickens · 2018-09-28T22:13:39Z

I'd be willing to jump in and either send a new PR or try to finish up whatever is remaining on this one. Any suggestions?

mkaito · 2018-10-03T22:54:05Z

The main concern is preserving data and config when upgrading to the new derivation. You can either write a script to take care of it, or show that nothing is lost during an upgrade.

colemickens · 2018-10-03T23:25:00Z

Are we concerned about downgrading as well? I didn't have to reconfigure when using this PR, so upgrading doesn't seem to damage the library. I can drop this and reconfirm locally, I just want to make sure we don't also need to worry about downgrade.

mkaito · 2018-10-04T16:22:04Z

No, not that I'm aware of. Upgrade should be fine. We're concerned mostly about avoiding people losing data when updating their systems. El 4 de octubre de 2018 0:25:09 GMT+01:00, Cole Mickens <notifications@github.com> escribió:

…

Are we concerned about downgrading as well? I didn't have to reconfigure when using this PR, so upgrading doesn't seem to damage the library. I can drop this and reconfirm locally, I just want to make sure we don't also need to worry about downgrade. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #38767 (comment)

-- Enviado desde mi dispositivo Android con K-9 Mail. Por favor, disculpa mi brevedad.

colemickens · 2018-10-08T04:57:59Z

I've just been flipping back and forth between channels/nixos-unstable and colemickens/nixpkgs@plex and Plex doesn't seem to miss a beat. I reloaded Firefox once but otherwise it just all seemed to work fine.

Note, I can't speak to every permutation. I've been running this module for a while. It's possible that a big version jump for older users might have different behaviors. But as far as I can tell, and from what I remember when I started using this PR... it's fine.

I confirmed by checking systemctl cat plex when flipping back and forth to ensure it was a different systemd unit (hence with and without the module rewrite).

colemickens · 2018-10-08T04:58:34Z

If it sounds okay, maybe @yegortimoshenko can rebase, or I can send a rebase/plex-updated PR to succeed this. Let me know.

colemickens · 2018-10-09T06:52:03Z

Here's a branch, rebased, with the latest Plex package. https://github.com/colemickens/nixpkgs/commits/plex

mkaito · 2018-10-10T14:09:43Z

@colemickens diff between my branch and yours. Why?

--- a/nixos/modules/services/misc/plex.nix
+++ b/nixos/modules/services/misc/plex.nix
@@ -56,12 +56,12 @@ in
     };

     users.users.plex = {
+      createHome = true;
       group = "plex";
+      home = cfg.dataDir;
       uid = config.ids.uids.plex;
     };

-    users.groups.plex = {
-      gid = config.ids.gids.plex;
-    };
+    users.groups.plex.gid = config.ids.gids.plex;
   };
 }

colemickens · 2018-10-10T23:41:41Z

@mkaito I don't know. That diff appears in the original PR form @yegortimoshenko. I'm not sure where your branch came from, etc.

As far as I know, my branch should be the same commits as the PR, just rebased, and then with one extra commit bumping up the version.

colemickens · 2018-10-11T19:42:15Z

(I do know that Plex (particularly in NixOS) has had issues in the past when it's home directory didn't exist ahead of time. Also, the other change looks like a syntax-only change as well.)

mkaito · 2018-10-13T00:43:05Z

I think it was probably a rebase gone bad at some point. 👍

lukateras · 2018-10-16T11:32:38Z

Superseded by #48506.

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Apr 11, 2018

matthewbauer added the 2.status: work-in-progress label Apr 21, 2018

lukateras closed this Jun 12, 2018

lukateras reopened this Jun 12, 2018

GrahamcOfBorg added the 2.status: merge conflict label Jun 12, 2018

mkaito force-pushed the 20180411.101856/plex branch from febd5ca to 72a68c0 Compare June 14, 2018 20:06

GrahamcOfBorg removed the 2.status: merge conflict label Jun 14, 2018

lukateras force-pushed the 20180411.101856/plex branch 4 times, most recently from 1ccca68 to 654f3bf Compare June 18, 2018 02:08

lukateras changed the title ~~[WIP] plex: use buildFHSUserEnv~~ plex: use buildFHSUserEnv Jun 18, 2018

lukateras removed the 2.status: work-in-progress label Jun 18, 2018

colemickens approved these changes Jun 19, 2018

View reviewed changes

colemickens reviewed Jun 19, 2018

View reviewed changes

plex: rewrite on top of buildFHSUserEnv

7996a26

mkaito force-pushed the 20180411.101856/plex branch from 11b3d6f to ce7a73a Compare June 19, 2018 12:29

plex: 1.9.6 -> 1.13.2

2ebfa1e

mkaito force-pushed the 20180411.101856/plex branch from ce7a73a to 2ebfa1e Compare June 19, 2018 12:32

mkaito approved these changes Jun 20, 2018

View reviewed changes

LnL7 reviewed Jun 21, 2018

View reviewed changes

mkaito mentioned this pull request Sep 19, 2018

XDG_RUNTIME_DIR is not set #46826

Closed

colemickens mentioned this pull request Oct 16, 2018

plex: use buildFHSUserEnv; update to 1.13.9.5439 #48506

Closed

9 tasks

lukateras closed this Oct 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

plex: use buildFHSUserEnv #38767

plex: use buildFHSUserEnv #38767

lukateras commented Apr 11, 2018 •

edited

mkaito commented May 2, 2018

colemickens commented May 30, 2018

colemickens commented Jun 12, 2018

colemickens commented Jun 18, 2018

colemickens Jun 19, 2018

mkaito commented Jun 19, 2018

GrahamcOfBorg commented Jun 19, 2018

GrahamcOfBorg commented Jun 19, 2018

GrahamcOfBorg commented Jun 19, 2018

mkaito left a comment

lukateras commented Jun 20, 2018

mkaito commented Jun 20, 2018

colemickens commented Jun 20, 2018

mkaito commented Jun 21, 2018

LnL7 Jun 21, 2018

lukateras Jun 21, 2018 •

edited

mkaito Jun 24, 2018

colemickens commented Jul 10, 2018

colemickens commented Aug 19, 2018

colemickens commented Sep 28, 2018

mkaito commented Oct 3, 2018

colemickens commented Oct 3, 2018

mkaito commented Oct 4, 2018 via email

colemickens commented Oct 8, 2018

colemickens commented Oct 8, 2018

colemickens commented Oct 9, 2018

mkaito commented Oct 10, 2018

colemickens commented Oct 10, 2018

colemickens commented Oct 11, 2018

mkaito commented Oct 13, 2018

lukateras commented Oct 16, 2018

plex: use buildFHSUserEnv #38767

plex: use buildFHSUserEnv #38767

Conversation

lukateras commented Apr 11, 2018 • edited

mkaito commented May 2, 2018

colemickens commented May 30, 2018

colemickens commented Jun 12, 2018

colemickens commented Jun 18, 2018

colemickens Jun 19, 2018

Choose a reason for hiding this comment

mkaito commented Jun 19, 2018

GrahamcOfBorg commented Jun 19, 2018

GrahamcOfBorg commented Jun 19, 2018

GrahamcOfBorg commented Jun 19, 2018

mkaito left a comment

Choose a reason for hiding this comment

lukateras commented Jun 20, 2018

mkaito commented Jun 20, 2018

colemickens commented Jun 20, 2018

mkaito commented Jun 21, 2018

LnL7 Jun 21, 2018

Choose a reason for hiding this comment

lukateras Jun 21, 2018 • edited

Choose a reason for hiding this comment

mkaito Jun 24, 2018

Choose a reason for hiding this comment

colemickens commented Jul 10, 2018

colemickens commented Aug 19, 2018

colemickens commented Sep 28, 2018

mkaito commented Oct 3, 2018

colemickens commented Oct 3, 2018

mkaito commented Oct 4, 2018 via email

colemickens commented Oct 8, 2018

colemickens commented Oct 8, 2018

colemickens commented Oct 9, 2018

mkaito commented Oct 10, 2018

colemickens commented Oct 10, 2018

colemickens commented Oct 11, 2018

mkaito commented Oct 13, 2018

lukateras commented Oct 16, 2018

lukateras commented Apr 11, 2018 •

edited

lukateras Jun 21, 2018 •

edited