Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask-autoindex: init at 0.6 #38784

Merged
merged 1 commit into from Apr 23, 2018
Merged

pythonPackages.flask-autoindex: init at 0.6 #38784

merged 1 commit into from Apr 23, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Depends on #38783, do not merge before that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner April 11, 2018 16:55
dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/python-modules/flask-autoindex/default.nix Outdated
meta = with stdenv.lib; {
description = "The mod_autoindex for Flask";
longDescription = ''
Flask-AutoIndex generates an index page for your Flask application automatically. The result just like mod_autoindex, but the look is more awesome!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split into two lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a standard for longDescription line length? In my opinion non-semantic linebreaks should be done by whatever renders the description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of any. But if there's a . in your longDescription, you should definitely add a line break.

dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/python-modules/flask-autoindex/default.nix Outdated
description = "The mod_autoindex for Flask";
longDescription = ''
Flask-AutoIndex generates an index page for your Flask application automatically.
The result just like mod_autoindex, but the look is more awesome!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a verb missing

@dotlambda dotlambda self-assigned this Apr 14, 2018
@timokau
Copy link
Member Author

timokau commented Apr 22, 2018

I rebased on master since the dependency is now merged.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.flask-autoindex python3.pkgs.flask-autoindex

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.flask-autoindex, python3.pkgs.flask-autoindex

Partial log (click to expand)

test_own_static_file (tests.ApplicationTestCase) ... /nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name='/build/Flask-AutoIndex-0.6/tests/static/helloworld.txt'>
  testMethod()
ok

----------------------------------------------------------------------
Ran 22 tests in 0.073s

OK
/nix/store/ah6f4cayy3dpan8m19c2882qx4m15sw7-python2.7-Flask-AutoIndex-0.6
/nix/store/j1sw0cvrkmj94jqc0w07s5xqyi7z7sk0-python3.6-Flask-AutoIndex-0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.flask-autoindex, python3.pkgs.flask-autoindex

Partial log (click to expand)

test_own_static_file (tests.ApplicationTestCase) ... /nix/store/qxix1jzfslmcbd75b024sgz704r94qxl-python3-3.6.5/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name='/build/Flask-AutoIndex-0.6/tests/static/helloworld.txt'>
  testMethod()
ok

----------------------------------------------------------------------
Ran 22 tests in 0.526s

OK
/nix/store/8w9asj3wiqhpi4qq89fg2ap5nfdhwhdw-python2.7-Flask-AutoIndex-0.6
/nix/store/v5wpyf5iz1kc2w80sgfwsmz0lwwkgq7f-python3.6-Flask-AutoIndex-0.6

dotlambda
dotlambda reviewed Apr 23, 2018
View reviewed changes
pkgs/development/python-modules/flask-autoindex/default.nix Outdated
postInstall = ''
# binary does not run, known issue and fixed in next release (>0.6)
# see https://github.com/sublee/flask-autoindex/pull/32
rm $out/bin/fai
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there will be a next release. Maybe use https://github.com/sublee/flask-autoindex/pull/32.patch as a patch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right. Done.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.flask-autoindex python3.pkgs.flask-autoindex

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.flask-autoindex, python3.pkgs.flask-autoindex

Partial log (click to expand)

test_own_static_file (tests.ApplicationTestCase) ... /nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name='/build/Flask-AutoIndex-0.6/tests/static/helloworld.txt'>
  testMethod()
ok

----------------------------------------------------------------------
Ran 22 tests in 0.102s

OK
/nix/store/3xm5kn4sb6nln0a6kf8kfmllahgpnj86-python2.7-Flask-AutoIndex-0.6
/nix/store/4ajla38ga1gz2m6qdqgxm5hbw7brs2wz-python3.6-Flask-AutoIndex-0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.flask-autoindex, python3.pkgs.flask-autoindex

Partial log (click to expand)

test_own_static_file (tests.ApplicationTestCase) ... /nix/store/qxix1jzfslmcbd75b024sgz704r94qxl-python3-3.6.5/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name='/build/Flask-AutoIndex-0.6/tests/static/helloworld.txt'>
  testMethod()
ok

----------------------------------------------------------------------
Ran 22 tests in 0.543s

OK
/nix/store/45sjnim6cdyvgga3zw63pjhzgkp6gn48-python2.7-Flask-AutoIndex-0.6
/nix/store/pvi186b1347bbx55wsjar1zx5h1lx1z8-python3.6-Flask-AutoIndex-0.6

@dotlambda dotlambda merged commit 16408d3 into NixOS:master Apr 23, 2018
@timokau timokau deleted the flask-autoindex-init branch April 23, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@dotlambda dotlambda

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg