Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask-babel: init at 0.11.2 #38786

Merged
merged 1 commit into from Apr 22, 2018
Merged

pythonPackages.flask-babel: init at 0.11.2 #38786

merged 1 commit into from Apr 22, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Package flask-babel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner April 11, 2018 16:58
dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/python-modules/flask-babel/default.nix Outdated
'';

meta = with stdenv.lib; {
description = "i18n and l10n support for Flask based on Babel and pytz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use

Adds i18n/l10n support to Flask applications

from PyPI and you get the capitalization required by https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.flask-babel python3.pkgs.flask-babel

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.flask-babel, python3.pkgs.flask-babel

Partial log (click to expand)

Ran 17 tests in 0.583s

OK
.................
----------------------------------------------------------------------
Ran 17 tests in 0.562s

OK
/nix/store/cqscjb7z6qgxp9bglnbg3y8400sp3ws5-python2.7-Flask-Babel-0.11.2
/nix/store/6pw4mzhcf2iwgqbmsyvxrjqlvh4nasl1-python3.6-Flask-Babel-0.11.2

dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/python-modules/flask-babel/default.nix Outdated
meta = with stdenv.lib; {
description = "Adds i18n/l10n support to Flask applications";
longDescription = ''
Implements i18n and l10n support for Flask. This is based on the Python babel module as well as pytz both of which are installed automatically for you if you install this library.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break

@dotlambda dotlambda self-assigned this Apr 14, 2018
@matthewbauer matthewbauer merged commit 1cf1b1e into NixOS:master Apr 22, 2018
@timokau timokau deleted the flask-babel-init branch April 22, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@dotlambda dotlambda

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @dotlambda @GrahamcOfBorg @matthewbauer