Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tealdeer: init at 1.0.0 #38766

Merged
merged 1 commit into from Apr 30, 2018
Merged

tealdeer: init at 1.0.0 #38766

merged 1 commit into from Apr 30, 2018

Conversation

davidak
Copy link
Member

@davidak davidak commented Apr 11, 2018 •
edited

Motivation for this change

fastest implementation of tldr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@davidak davidak force-pushed the tealdeer branch 3 times, most recently from 8d46c8d to f84182e Compare April 11, 2018 12:52
@davidak davidak changed the title tealdeer: init at 1.0.0 [WIP] tealdeer: init at 1.0.0 Apr 11, 2018
@davidak
Copy link
Member Author

davidak commented Apr 11, 2018

Currently i have problems on darwin since it looks for CACerts in /etc/ssh/cert.pem what don't exist.

Maybe the current version works, but i have to compile many packages. Could take some hours.

This seem still to be a huge issue #8247

@davidak
Copy link
Member Author

davidak commented Apr 12, 2018

With my last change it also works on darwin \o/

@davidak davidak changed the title [WIP] tealdeer: init at 1.0.0 tealdeer: init at 1.0.0 Apr 12, 2018
@xeji
Copy link
Contributor

xeji commented Apr 30, 2018

@GrahamcOfBorg eval

@xeji xeji merged commit 2f4e3f9 into NixOS:master Apr 30, 2018
@davidak davidak deleted the tealdeer branch July 30, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidak @xeji @GrahamcOfBorg