Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m4ri: init at 20140914 #38762

Merged
merged 1 commit into from Apr 12, 2018
Merged

m4ri: init at 20140914 #38762

merged 1 commit into from Apr 12, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Package m4ri.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This was referenced Apr 11, 2018
Merged
Merged
dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/libraries/science/math/m4ri/default.nix Outdated
homepage = http://m4ri.sagemath.org/;
description = "Library for matrix multiplication, reduction and inversion over GF(2)";
longDescription = ''
M4RIE is a library for fast arithmetic with dense matrices over small finite fields of even characteristic. It uses the M4RI library, implementing the same operations over the finite field F2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the description for m4rie.

pkgs/development/libraries/science/math/m4ri/default.nix Outdated
'';
license = with licenses; [ gpl2 ];
maintainers = with maintainers; [ timokau ];
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested all platforms? It's generally better to set to Linux only or to platforms.unix if Darwin was also tested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I know that it works on various platforms in the sage distribution (including ARM, darwin, cygwin) so I have reasonable hope that it'll work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set platforms = platforms.linux until someone builds this on macOS.

pkgs/development/libraries/science/math/m4ri/default.nix Outdated
];

meta = with stdenv.lib; {
homepage = http://m4ri.sagemath.org/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be down

@dotlambda
Copy link
Member

@GrahamcOfBorg build m4ri

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: m4ri

Partial log (click to expand)

make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/55ks5wa515m2px5zfzwwfch7380bzl5c-m4ri-20140914
shrinking /nix/store/55ks5wa515m2px5zfzwwfch7380bzl5c-m4ri-20140914/lib/libm4ri-0.0.20140914.so
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/55ks5wa515m2px5zfzwwfch7380bzl5c-m4ri-20140914/lib
patching script interpreter paths in /nix/store/55ks5wa515m2px5zfzwwfch7380bzl5c-m4ri-20140914
checking for references to /build in /nix/store/55ks5wa515m2px5zfzwwfch7380bzl5c-m4ri-20140914...
/nix/store/55ks5wa515m2px5zfzwwfch7380bzl5c-m4ri-20140914

dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/libraries/science/math/m4ri/default.nix Outdated
homepage = https://malb.bitbucket.io/m4ri/;
description = "Library to do fast arithmetic with dense matrices over F_2";
longDescription = ''
M4RIE is a library for fast arithmetic with dense matrices over small finite fields of even characteristic. It uses the M4RI library, implementing the same operations over the finite field F2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still the wrong longDescription.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I meant to delete that.

@timokau
Copy link
Member Author

timokau commented Apr 12, 2018

Thanks for taking the time to review and sorry for my oversights @dotlambda.

dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/libraries/science/math/m4ri/default.nix Outdated
meta = with stdenv.lib; {
homepage = https://malb.bitbucket.io/m4ri/;
description = "Library to do fast arithmetic with dense matrices over F_2";
license = with licenses; [ gpl2 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M4RI is available under the General Public License Version 2 or later (GPLv2+)

It should be

license = licenses.gpl2Plus;

@dotlambda dotlambda merged commit 077bf8d into NixOS:master Apr 12, 2018
@timokau timokau deleted the m4ri-init branch April 12, 2018 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg