Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: 2.16.2 -> 2.17.0 #38763

Merged
merged 3 commits into from Apr 12, 2018
Merged

git: 2.16.2 -> 2.17.0 #38763

merged 3 commits into from Apr 12, 2018

Conversation

layus
Copy link
Member

@layus layus commented Apr 11, 2018 •
edited

Fixed the perl lib path issues detected in #38636

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@layus layus force-pushed the git-2.17.0 branch 3 times, most recently from 3e58532 to 39a1137 Compare April 11, 2018 15:52
@layus layus changed the base branch from master to staging April 11, 2018 15:53
@layus
Copy link
Member Author

layus commented Apr 11, 2018

There is such a mess now with the staging merges and reverts interleaved.
This one should be merged to staging, and 2601941 to master.

@LnL7
Copy link
Member

LnL7 commented Apr 11, 2018

Yeah, staging.

@dtzWill
Copy link
Member

dtzWill commented Apr 11, 2018

Thanks for tackling this!

@dtzWill dtzWill mentioned this pull request Apr 11, 2018
Merged
8 tasks
@peti peti merged commit e8f0cb9 into NixOS:staging Apr 12, 2018
peti pushed a commit that referenced this pull request Apr 12, 2018
@dtzWill @peti
git: 2.16.2 -> 2.16.3
281775b 
Cherry picked from 2601941 in staging as suggested by
#38763 (comment).
globin pushed a commit to mayflower/nixpkgs that referenced this pull request May 24, 2018
@dtzWill @globin
git: 2.16.2 -> 2.16.3
27d4f94 
Cherry picked from 2601941 in staging as suggested by
NixOS#38763 (comment).

(cherry picked from commit 281775b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@layus @LnL7 @dtzWill @peti @GrahamcOfBorg