Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 2.4.0 -> 2.5.0 #38753

Merged
merged 1 commit into from Apr 11, 2018
Merged

radare2: 2.4.0 -> 2.5.0 #38753

merged 1 commit into from Apr 11, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 11, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 11, 2018

cc @raskin @makefu

@7c6f434c
Copy link
Member

@GrahamcOfBorg build radare2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2

Partial log (click to expand)

shrinking /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/lib/libr_bin.so.2.4.0
shrinking /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/lib/libr_reg.so.2.4.0
gzipping man pages under /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/lib  /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/bin
patching script interpreter paths in /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0
/nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
checking for references to /tmp/nix-build-radare2-2.5.0.drv-0 in /nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0...
/nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0

@7c6f434c
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2

Partial log (click to expand)

shrinking /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/lib/libr_asm.so.2.4.0
shrinking /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/lib/libr_anal.so.2.4.0
gzipping man pages under /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/lib  /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/bin
patching script interpreter paths in /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0
/nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/bin/ragg2-cc: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
/nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0/bin/r2pm: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0...
/nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2

Partial log (click to expand)

/nix/store/r4fj8q8vj2pwmavzgn2nqq43d3ilsrqv-radare2-2.5.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2

Partial log (click to expand)

/nix/store/13knhhlyw0g896867a95k59j5dg9y92j-radare2-2.5.0

@7c6f434c 7c6f434c merged commit 53a317b into NixOS:master Apr 11, 2018
@Mic92 Mic92 deleted the radare2 branch April 11, 2018 10:51
@dtzWill
Copy link
Member

dtzWill commented Apr 11, 2018

This updates the wrong hash (not sure how/why that was needed), and as a result is still radare2 2.4.0 instead of 2.5.0. :(

@dtzWill dtzWill mentioned this pull request Apr 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @7c6f434c @GrahamcOfBorg @dtzWill