Fix HTTP::ChunkedContent#peek return empty bytes at EOF #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Apr 11, 2018
sdogruyol
approved these changes
Apr 12, 2018
|
I don't understand. If you can't peek, shouldn't it raise? Just like trying to seek will raise. Other cases such as gets return a nilable. It's confusing :/ |
|
@ysbaddaden The docs for
|
|
OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5928 was merged I noticed the implementation of
#peekwas incorrect: it is supposed to return an empty slice at EOF but returnednilinstead (which would mean the IO is not peekable).That was already broken before, so it was not recognized in the PR.