pythonPackages.fpylll: init at 0.3.0dev #38790

timokau · 2018-04-11T17:09:55Z

Motivation for this change

~~This depends on #38781, do not merge before that.~~

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-04-12T16:50:37Z

pkgs/development/python-modules/fpylll/default.nix

+  ];
+
+  meta = {
+    description = "A Python interface for fpylll";


A Python interface for fplll

dotlambda

The website says

fpylll also relies on py.test for testing Python

Please specify an appropriate checkPhase.

timokau · 2018-04-13T15:38:21Z

I added the checkPhase, added a fplll upgrade that is necessary for fpylll and added a numpy dependency to pass the tests.

dotlambda · 2018-04-13T15:40:08Z

pkgs/development/python-modules/fpylll/default.nix

+  meta = {
+    description = "A Python interface for fplll";
+    homepage = https://github.com/fplll/fpylll;
+    maintainers = with lib.maintainers; [ timokau ];


dotlambda · 2018-04-13T15:40:31Z

pkgs/development/python-modules/fpylll/default.nix

+    fplll
+    cython
+    cysignals
+    numpy


Some of these belong in propagatedBuildInputs.

dotlambda · 2018-04-13T15:52:04Z

pkgs/development/python-modules/fpylll/default.nix

+    description = "A Python interface for fplll";
+    homepage = https://github.com/fplll/fpylll;
+    maintainers = with lib.maintainers; [ timokau ];
+    license = lib.licenses.gpl2;


fpylll is licensed under the GPLv2+

https://github.com/fplll/fpylll#attribution--license

Oh, I only checked the LICENSE file.

dotlambda · 2018-04-14T07:30:30Z

@GrahamcOfBorg build python2.pkgs.fpyll python3.pkgs.fpyll

GrahamcOfBorg · 2018-04-14T07:30:49Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.fpyll, python3.pkgs.fpyll

Partial log (click to expand)

Cannot nix-instantiate `python2.pkgs.fpyll' because:
error: attribute ‘fpyll’ in selection path ‘python2.pkgs.fpyll’ not found

Cannot nix-instantiate `python3.pkgs.fpyll' because:
error: attribute ‘fpyll’ in selection path ‘python3.pkgs.fpyll’ not found

GrahamcOfBorg · 2018-04-14T07:30:49Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.fpyll, python3.pkgs.fpyll

Partial log (click to expand)

Cannot nix-instantiate `python2.pkgs.fpyll' because:
�[31;1merror:�[0m attribute 'fpyll' in selection path 'python2.pkgs.fpyll' not found

Cannot nix-instantiate `python3.pkgs.fpyll' because:
�[31;1merror:�[0m attribute 'fpyll' in selection path 'python3.pkgs.fpyll' not found

dotlambda · 2018-04-14T07:32:36Z

@GrahamcOfBorg build python2.pkgs.fpyll python3.pkgs.fpylll

GrahamcOfBorg · 2018-04-14T07:35:50Z

Success on x86_64-linux (full log)

Attempted: python3.pkgs.fpylll

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.fpyll

Partial log (click to expand)

tests/test_numpy.py ..                                                   [ 70%]
tests/test_precision.py .                                                [ 75%]
tests/test_pruner.py .                                                   [ 79%]
tests/test_random.py .                                                   [ 83%]
tests/test_simple_bkz.py ..                                              [ 91%]
tests/test_strategies.py .                                               [ 95%]
tests/test_util.py .                                                     [100%]

========================== 24 passed in 21.62 seconds ==========================
/nix/store/zmkqa0y4dqba09z2wppw5dssnm4qpgc6-python3.6-fpylll-0.3.0dev

dotlambda · 2018-04-14T07:38:48Z

@GrahamcOfBorg build python2.pkgs.fpylll python3.pkgs.fpylll

GrahamcOfBorg · 2018-04-14T07:40:29Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.fpylll, python3.pkgs.fpylll

Partial log (click to expand)

tests/test_precision.py .                                                [ 75%]
tests/test_pruner.py .                                                   [ 79%]
tests/test_random.py .                                                   [ 83%]
tests/test_simple_bkz.py ..                                              [ 91%]
tests/test_strategies.py .                                               [ 95%]
tests/test_util.py .                                                     [100%]

========================== 24 passed in 20.36 seconds ==========================
/nix/store/fxxl73a71kq1kr7naxx0g4hf63zq4a9k-python2.7-fpylll-0.3.0dev
/nix/store/zmkqa0y4dqba09z2wppw5dssnm4qpgc6-python3.6-fpylll-0.3.0dev

GrahamcOfBorg · 2018-04-14T08:33:06Z

Failure on aarch64-linux (full log)

Attempted: python3.pkgs.fpylll

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.fpyll

Partial log (click to expand)

                 from memoryviewattrs.cpp:580:
/nix/store/i8py6fv0irvkl3s3kndqpw8szl1rzcic-python3.6-numpy-1.14.2/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/l60jan1mgs2yd0lnkmsprzjapx4rynv9-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/bc3rqbznfssmzrpc90wgm6aygjqpb60v-python3.6-cysignals-1.6.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nmrkn3c8lb7yvvkd4a42g90grba3qyrg-python3.6-fpylll-0.3.0dev.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/nmrkn3c8lb7yvvkd4a42g90grba3qyrg-python3.6-fpylll-0.3.0dev.drv' failed

timokau · 2018-04-14T08:41:31Z

building of '/nix/store/l60jan1mgs2yd0lnkmsprzjapx4rynv9-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds

Maybe ofBorg should indicate when a failure is due to a timeout.

GrahamcOfBorg · 2018-04-14T09:33:10Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.fpylll, python3.pkgs.fpylll

Partial log (click to expand)

                 from memoryviewattrs.cpp:580:
/nix/store/i8py6fv0irvkl3s3kndqpw8szl1rzcic-python3.6-numpy-1.14.2/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/l60jan1mgs2yd0lnkmsprzjapx4rynv9-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/bc3rqbznfssmzrpc90wgm6aygjqpb60v-python3.6-cysignals-1.6.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nmrkn3c8lb7yvvkd4a42g90grba3qyrg-python3.6-fpylll-0.3.0dev.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/ibiqnqwa42cjpi1bpnfvvdclmjnzicfm-python2.7-fpylll-0.3.0dev.drv', '/nix/store/nmrkn3c8lb7yvvkd4a42g90grba3qyrg-python3.6-fpylll-0.3.0dev.drv' failed

timokau requested a review from FRidh as a code owner April 11, 2018 17:09

GrahamcOfBorg added the 6.topic: python label Apr 11, 2018

dotlambda reviewed Apr 12, 2018

View reviewed changes

dotlambda requested changes Apr 12, 2018

View reviewed changes

fplll: 5.0.2 -> 5.2.0

bca79a9

timokau force-pushed the fpylll-init branch from 83036c6 to 15392d9 Compare April 13, 2018 15:37

dotlambda reviewed Apr 13, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 13, 2018

timokau force-pushed the fpylll-init branch from 15392d9 to 4d0389c Compare April 13, 2018 15:49

dotlambda reviewed Apr 13, 2018

View reviewed changes

pythonPackages.fpylll: init at 0.3.0dev

633f694

timokau force-pushed the fpylll-init branch from 4d0389c to 633f694 Compare April 13, 2018 16:23

dotlambda merged commit 2a09342 into NixOS:master Apr 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.fpylll: init at 0.3.0dev #38790

pythonPackages.fpylll: init at 0.3.0dev #38790

timokau commented Apr 11, 2018 •

edited

dotlambda Apr 12, 2018

dotlambda left a comment

timokau commented Apr 13, 2018

dotlambda Apr 13, 2018

timokau Apr 13, 2018

dotlambda Apr 13, 2018

dotlambda Apr 13, 2018

timokau Apr 13, 2018

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

timokau commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

pythonPackages.fpylll: init at 0.3.0dev #38790

pythonPackages.fpylll: init at 0.3.0dev #38790

Conversation

timokau commented Apr 11, 2018 • edited

Motivation for this change

Things done

dotlambda Apr 12, 2018

Choose a reason for hiding this comment

dotlambda left a comment

Choose a reason for hiding this comment

timokau commented Apr 13, 2018

dotlambda Apr 13, 2018

Choose a reason for hiding this comment

timokau Apr 13, 2018

Choose a reason for hiding this comment

dotlambda Apr 13, 2018

Choose a reason for hiding this comment

dotlambda Apr 13, 2018

Choose a reason for hiding this comment

timokau Apr 13, 2018

Choose a reason for hiding this comment

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

dotlambda commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

timokau commented Apr 14, 2018

GrahamcOfBorg commented Apr 14, 2018

timokau commented Apr 11, 2018 •

edited