Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add green checkmarks #159

Merged
merged 9 commits into from Apr 11, 2018
Merged

add green checkmarks #159

merged 9 commits into from Apr 11, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 11, 2018 •
edited

@grahamc
Copy link
Member

grahamc commented Apr 11, 2018

😻

LnL7
LnL7 commented Apr 11, 2018
View reviewed changes
ofborg/test-srcs/make-pr.sh Outdated
@@ -1,36 +1,24 @@
#!/bin/sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be #!/usr/bin/env bash to avoid other POSIX sh issues in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@grahamc grahamc closed this Apr 11, 2018
@grahamc grahamc reopened this Apr 11, 2018
@grahamc grahamc merged commit ee6fb69 into NixOS:next Apr 11, 2018
@LnL7 LnL7 deleted the test-travis branch April 11, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @grahamc @shlevy