Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KSP-CKAN/CKAN
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b674f69adbea
Choose a base ref
...
head repository: KSP-CKAN/CKAN
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 35a49f755a4d
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 9, 2018

  1. Don't double encode GitHub download URLs

    @HebaruSan
    HebaruSan committed Apr 9, 2018
    Copy the full SHA
    7894581 View commit details

Commits on Apr 11, 2018

  1. Merge #2402 Don't double encode GitHub download URLs

    @politas
    politas committed Apr 11, 2018
    Copy the full SHA
    35a49f7 View commit details
Showing with 2 additions and 1 deletion.
  1. +1 −0 CHANGELOG.md
  2. +1 −1 Netkan/Transformers/GithubTransformer.cs
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -32,6 +32,7 @@ All notable changes to this project will be documented in this file.
- [GUI] More verbose and accurate version displays (#2382 by: HebaruSan; reviewed: politas)
- [Core] Encode spaces in URL output (#2386 by: HebaruSan; reviewed: politas)
- [Multiple] Clean-up and debuggability (#2399 by: HebaruSan; reviewed: politas)
- [Netkan] Don't double encode GitHub download URLs (#2402 by: HebaruSan; reviewed: politas)

### Internal

2 changes: 1 addition & 1 deletion Netkan/Transformers/GithubTransformer.cs
View file
Original file line number Diff line number Diff line change
@@ -75,7 +75,7 @@ public Metadata Transform(Metadata metadata)
{
json.SafeAdd("version", ghRelease.Version.ToString());
json.SafeAdd("author", ghRelease.Author);
json.SafeAdd("download", Uri.EscapeUriString(ghRelease.Download.ToString()));
json.SafeAdd("download", ghRelease.Download.ToString());
json.SafeAdd(Model.Metadata.UpdatedPropertyName, ghRelease.AssetUpdated);

if (ghRef.Project.Contains("_"))