Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask-silk: init at 0.2 #38783

Merged
merged 1 commit into from Apr 22, 2018
Merged

pythonPackages.flask-silk: init at 0.2 #38783

merged 1 commit into from Apr 22, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 11, 2018 •
edited

Motivation for this change

Package flask-silk.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner April 11, 2018 16:51
@timokau timokau mentioned this pull request Apr 11, 2018
Merged
8 tasks
dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -5605,6 +5605,7 @@ in {
flask-restplus = callPackage ../development/python-modules/flask-restplus { };

flask_script = callPackage ../development/python-modules/flask-script { };
flask-silk = callPackage ../development/python-modules/flask-silk { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.flask-silk python3.pkgs.flask-silk

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.flask-silk, python3.pkgs.flask-silk

Partial log (click to expand)

ok
test_subdomain (test.ModuleTestCase) ... ok
test_urlprefix (test.ModuleTestCase) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.134s

OK
/nix/store/yf99dn42skrvv5q574maqq8mvic3gmnv-python2.7-Flask-Silk-0.2
/nix/store/sj5g2xq7ln8f628qdh6056ym33br0i6g-python3.6-Flask-Silk-0.2

dotlambda
dotlambda reviewed Apr 12, 2018
View reviewed changes
pkgs/development/python-modules/flask-silk/default.nix Outdated
];

meta = with stdenv.lib; {
description = "Adds silk icons to your Flask application or module, or extension.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to review the things I mention in all your other PRs as well.

@timokau timokau force-pushed the flask-silk-init branch 2 times, most recently from 6e71bf9 to 0cff11a Compare April 12, 2018 10:48
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.flask-silk python3.pkgs.flask-silk

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.flask-silk, python3.pkgs.flask-silk

Partial log (click to expand)

test_icon (test.ApplicationTestCase) ... /nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/lib/python3.6/unittest/case.py:605: ResourceWarning: unclosed file <_io.BufferedReader name='/tmp/nix-build-python3.6-Flask-Silk-0.2.drv-0/Flask-Silk-0.2/flask_silk/icons/page_white.png'>
  testMethod()
ok
test_subdomain (test.ModuleTestCase) ... ok
test_urlprefix (test.ModuleTestCase) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.029s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.flask-silk, python3.pkgs.flask-silk

Partial log (click to expand)

ok
test_subdomain (test.ModuleTestCase) ... ok
test_urlprefix (test.ModuleTestCase) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.102s

OK
/nix/store/yf99dn42skrvv5q574maqq8mvic3gmnv-python2.7-Flask-Silk-0.2
/nix/store/sj5g2xq7ln8f628qdh6056ym33br0i6g-python3.6-Flask-Silk-0.2

@dotlambda dotlambda self-assigned this Apr 14, 2018
dotlambda
dotlambda reviewed Apr 14, 2018
View reviewed changes
pkgs/development/python-modules/flask-silk/default.nix Outdated

meta = with stdenv.lib; {
description = "Adds silk icons to your Flask application or module, or extension";
license = licenses.bsd2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sublee/flask-silk/blob/master/LICENSE looks like bsd3 to me

Copy link
Member Author

@timokau timokau Apr 15, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going after wikipedia[1], which doesn't list a bsd3. Why do you think its 3 and not 2?

[1] https://en.wikipedia.org/wiki/BSD_licenses#3-clause_license_(%22BSD_License_2.0%22,_%22Revised_BSD_License%22,_%22New_BSD_License%22,_or_%22Modified_BSD_License%22)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In

nixpkgs/lib/licenses.nix

Lines 92 to 95 in 92f0d31

bsd3 = spdx {
spdxId = "BSD-3-Clause";
fullName = ''BSD 3-clause "New" or "Revised" License'';
};

you can see that bsd3 stands for the 3-clause version. Flask-silk's license is a variant of the 3-clause version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see.

@matthewbauer matthewbauer merged commit 9897e95 into NixOS:master Apr 22, 2018
@timokau timokau deleted the flask-silk-init branch April 22, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@dotlambda dotlambda

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @dotlambda @GrahamcOfBorg @matthewbauer