cypari2: init at 1.1.4 #38782
cypari2: init at 1.1.4 #38782
Conversation
It looks good.
Does upstream know? I've removed the |
From the README:
Yes it builds, but it does not generate that one file, which is supposed to be generated and dependet upon by |
|
Can you add the explanation as a comment to the expression. |
|
Done |
| ]; | ||
|
|
||
| checkPhase = '' | ||
| make check |
There was a problem hiding this comment.
This should be the default. See https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh for future reference.
There was a problem hiding this comment.
Actually that's not the default for Python so nevermind.
| # This differs slightly from the default python installPhase in that it pip-installs | ||
| # "." instead of "*.whl". | ||
| # That is because while the default install phase succeeds to build the package, | ||
| # it fails to generate the file "auto_paridecl.pxd". |
There was a problem hiding this comment.
This is interesting... Could you try something like this instead of the installPhase (not sure if will work):
installFlags = "*.pxd";
That makes things a little simpler hopefully.
There was a problem hiding this comment.
That doesn't work. The default installPhase runs:
${bootstrapped-pip}/bin/pip install *.whl --no-index --prefix=$out --no-cache ${toString installFlags} --build tmpbuild
Motivation for this change
This depends on #38781, do not merge before thatPackage cypari2. The
installPhaseshould probably be reviewed as it is non-standarad and I'm not entirely sure if thats the best way to do it. With the standardinstallPhasethe required fileauto_paridecl.pxdis not generated.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)