Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for weechat #38428

Merged
merged 3 commits into from Apr 4, 2018
Merged

Add documentation for weechat #38428

merged 3 commits into from Apr 4, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Apr 4, 2018

Motivation for this change

It took me quite some time to understand there actually was documentation for weechat, so here are a few more pointers to the right place.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Apr 4, 2018

Just in case: @lovek323 @garbas @the-kenny @lheckemann

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat

Partial log (click to expand)

   0
  0 --:-
-:-- --
:--:--
--:--:--
     0

100   484  100   484    0     0    484      0  0:00:01 --:--:--  0:00:01  2
338

building path(s) ‘/nix/store/8vnlbicfqn5bds6nlccyxzsxzzfgsb94-weechat’

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat

Partial log (click to expand)

checking for references to /build in /nix/store/7xbww5qxgdahjhji155p6h6nxkbjrpvz-weechat-2.0-lua...
shrinking RPATHs of ELF executables and libraries in /nix/store/q5d0rzzd9zvfh04harrmxpvyklc8f1cw-weechat-2.0-python
shrinking /nix/store/q5d0rzzd9zvfh04harrmxpvyklc8f1cw-weechat-2.0-python/lib/weechat/plugins/python.so
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q5d0rzzd9zvfh04harrmxpvyklc8f1cw-weechat-2.0-python/lib
patching script interpreter paths in /nix/store/q5d0rzzd9zvfh04harrmxpvyklc8f1cw-weechat-2.0-python
checking for references to /build in /nix/store/q5d0rzzd9zvfh04harrmxpvyklc8f1cw-weechat-2.0-python...
building '/nix/store/04i3hf29gynk902qsxyk7mibwskcr7dv-weechat-plugins.drv'...
building '/nix/store/hhvi97gciiakg9prg97zkpp31wv422jc-weechat.drv'...
/nix/store/80b09f4ircy1k80j99wjvj1hb9ffi1by-weechat

@7c6f434c 7c6f434c merged commit ed1312f into NixOS:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ekleog @7c6f434c @GrahamcOfBorg @lheckemann