Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3b: fix build inputs and library/binary paths #38437

Merged
merged 1 commit into from Apr 9, 2018
Merged

k3b: fix build inputs and library/binary paths #38437

merged 1 commit into from Apr 9, 2018

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Apr 4, 2018

Motivation for this change

Fix #38325

I followed the instructions from this comment:
#38325 (comment)

cc: @Mic92

I'm not certain about the following matters:

  • Should only libcdparanoia be in the library path, not flac?
  • Should libcdparanoia or flac be removed from propagated build inputs?
  • Are there some other libraries missing from the library path?
  • Are there some other improvements that should be made?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from ttuegel as a code owner April 4, 2018 16:16
@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

propagedBuildInputs will not work for anything but propagating build input from from package to a different one. Sometimes it make things work by accident if a nix-shell is used, which also downloads propagatedBuildInputs. However it seems not the case that k3b is a dependency for anything, therefore all libraries should be moved to buildInputs and everything that is a runtime dependency and is not linked should be added to environment variables such as PATH/LD_LIBRARY_PATH (depending if it is a library or command line tool).

@jluttine jluttine mentioned this pull request Apr 4, 2018
Closed
@jluttine
Copy link
Member Author

jluttine commented Apr 4, 2018

Ok, I'm working on fixing these.

@jluttine
Copy link
Member Author

jluttine commented Apr 4, 2018

Made the following fixes:

  • cdparanoia into library path
  • flac into bin path
  • propagated build inputs to build inputs

At least the original issue is fixed. It's possible that there are some other packages that should be still added to library or binary path but don't know about those.

@jluttine jluttine changed the title k3b: add cdparanoia and flac to library path k3b: fix build inputs and library/binary paths Apr 4, 2018
@matthewbauer matthewbauer merged commit d6ce485 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @Mic92 @matthewbauer @GrahamcOfBorg