Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: 0.16.24 -> 0.16.36 #38427

Merged
merged 2 commits into from Apr 4, 2018
Merged

factorio: 0.16.24 -> 0.16.36 #38427

merged 2 commits into from Apr 4, 2018

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Apr 4, 2018 •
edited

Motivation for this change

Update factorio with latest stable

Things done

Update all packages to their latest version. Experimental version is lower than stable because there has not been an experimental release since the stable (which was this Monday).

Added an entry in all-packages.nix for factorio-headless-experimental, which was missing.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Michishige Kaito added 2 commits April 4, 2018 13:17
Add missing package factorio-headless-experimental
ff20c6c 
All combinations of headless/alpha and stable/experimental were present,
except for this one.
factorio: 16.24 -> 16.36
f56b733 
Update all factorio packages to their latest version. The fact that the
experimental version is lower than the alpha version is just because
they haven't made an experimental release after the last stable.
@Mic92 Mic92 merged commit a4581f5 into NixOS:master Apr 4, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

18.03 backport:

Recorded resolution for 'pkgs/top-level/all-packages.nix'.
[detached HEAD 68ddf22] Add missing package factorio-headless-experimental
Author: Michishige Kaito me@mkaito.com
Date: Wed Apr 4 13:17:33 2018 +0100
1 file changed, 2 insertions(+)
[detached HEAD 3aa9375] factorio: 16.24 -> 16.36
Author: Michishige Kaito me@mkaito.com
Date: Wed Apr 4 13:18:15 2018 +0100
1 file changed, 6 insertions(+), 6 deletions(-)

@mkaito mkaito deleted the update-factorio branch April 4, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkaito @Mic92 @GrahamcOfBorg