Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package set changes #38439

Merged
merged 105 commits into from Apr 4, 2018
Merged

Python package set changes #38439

merged 105 commits into from Apr 4, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Apr 4, 2018

Motivation for this change

Includes:

Hydra evaluation:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

etu added 30 commits April 4, 2018 19:45
Also disable on Py3k due to syntax errors.
@FRidh
Copy link
Member Author

FRidh commented Apr 4, 2018

@dotlambda I did not cherry-pick the commit, but made the minor changes myself.

@FRidh
Copy link
Member Author

FRidh commented Apr 4, 2018

The queue is quite small, so we can likely merge this into staging tonight. After that, I'll push again to this branch major version bumps. They will need fixing though...

@dotlambda
Copy link
Member

@dotlambda
Copy link
Member

Oh sorry, I overlooked

Bumps will be done later when upgrading the whole set

@dotlambda
Copy link
Member

Shouldn't we add the bumps I did to the second PR as well?

@FRidh
Copy link
Member Author

FRidh commented Apr 4, 2018

Its quite unlikely they cause breakage and if they do, its only few to fix.

@dotlambda
Copy link
Member

aioimaplib failure seems to be due to python3: 3.6.4 -> 3.6.5. I opened an upstream issue about it: bamthomas/aioimaplib#35

@dotlambda
Copy link
Member

cryptacular also seems to break because of Python 3.6.5:

crypt_blowfish-1.2/crypt.h:17:10: fatal error: gnu-crypt.h: No such file or directory

Do you know of a change that could be causing this?

@dotlambda
Copy link
Member

Moinmoin, for example, is not running any tests for me locally (Ran 0 tests in 0.000s). I have no idea why that's different from the Hydra build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants