Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware-linux-nonfree: Update SHA and add rev to prevent breakage #38436

Merged
merged 1 commit into from Apr 4, 2018
Merged

firmware-linux-nonfree: Update SHA and add rev to prevent breakage #38436

merged 1 commit into from Apr 4, 2018

Conversation

coreyoconnor
Copy link
Contributor

@coreyoconnor coreyoconnor commented Apr 4, 2018 •
edited

Motivation for this change
  1. recent push to linux firmware git broke build of this package. Without the rev attribute the HEAD of master is used which will result in a broken build every upstream commit.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

is a backport required?

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

@GrahamcOfBorg build firmware-linux-nonfree

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: firmware-linux-nonfree

Partial log (click to expand)

Cannot nix-instantiate `firmware-linux-nonfree' because:
�[31;1merror:�[0m attribute 'firmware-linux-nonfree' in selection path 'firmware-linux-nonfree' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: firmware-linux-nonfree

Partial log (click to expand)

Cannot nix-instantiate `firmware-linux-nonfree' because:
�[31;1merror:�[0m attribute 'firmware-linux-nonfree' in selection path 'firmware-linux-nonfree' not found

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

@GrahamcOfBorg build firmwareLinuxNonfree microcodeAmd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: firmwareLinuxNonfree, microcodeAmd

Partial log (click to expand)

building
installing
48 blocks
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0y3x2r81gw0293qvkjdd0kzarsls4d3a-amd-ucode-2018-03-20
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/0y3x2r81gw0293qvkjdd0kzarsls4d3a-amd-ucode-2018-03-20
checking for references to /build in /nix/store/0y3x2r81gw0293qvkjdd0kzarsls4d3a-amd-ucode-2018-03-20...
/nix/store/kp33vsmh3bx7dy8xzz76zzpfjasflzqx-firmware-linux-nonfree-2018-03-20
/nix/store/0y3x2r81gw0293qvkjdd0kzarsls4d3a-amd-ucode-2018-03-20

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: firmwareLinuxNonfree, microcodeAmd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92 Mic92 merged commit 1d3bd38 into NixOS:master Apr 4, 2018
@coreyoconnor
Copy link
Contributor Author

@Mic92 Probably. Given how fetchgit works without rev I think this would effect 18.03 release as well.

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2018

[detached HEAD 6efb3d2] firmware-linux-nonfree: Update SHA and add rev to prevent breakage on future commits.
Author: Corey O'Connor coreyoconnor@gmail.com
Date: Tue Apr 3 22:00:12 2018 -0700
1 file changed, 2 insertions(+), 1 deletion(-)

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: firmware-linux-nonfree

Partial log (click to expand)

Cannot nix-instantiate `firmware-linux-nonfree' because:
error: attribute 'firmware-linux-nonfree' in selection path 'firmware-linux-nonfree' not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: firmwareLinuxNonfree, microcodeAmd

Partial log (click to expand)


1
3
.
6
M


/nix/store/mxr2370adkj2f5sn5y0p2b3z4nwadgqb-firmware-linux-nonfree-2018-03-20
/nix/store/4bwhiivbdfv7f0bwish59w121k0cxkyr-amd-ucode-2018-03-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coreyoconnor @Mic92 @GrahamcOfBorg