wine: correct install order for WoW wine build. #37064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the wiki at https://wiki.winehq.org/Building_Wine#Shared_WoW64 "if you do choose to install your WoW64 build, you should run make install in the 32-bit build tree first, then in the 64-bit one." This is required, for instance, for the resulting "wineserver" executable to be the 64 bit variant not 32 bit. Which is expected by the binary loader for WoW64. This odd dependency is vaguely mentioned on the packaging wiki page: * https://wiki.winehq.org/Packaging#Binaries
|
also backported to 18.03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the wiki at https://wiki.winehq.org/Building_Wine#Shared_WoW64
"if you do choose to install your WoW64 build, you should run make
install in the 32-bit build tree first, then in the 64-bit one."
This is required, for instance, for the resulting "wineserver"
executable to be the 64 bit variant not 32 bit. Which is expected by the
binary loader for WoW64.
This odd dependency is vaguely mentioned on the packaging wiki page:
Build with nixpkgs config option
wine.build = "wineWow";.Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)