Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st: 0.7 -> 0.8 #37105

Merged
merged 1 commit into from Mar 17, 2018
Merged

st: 0.7 -> 0.8 #37105

merged 1 commit into from Mar 17, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Mar 15, 2018 •
edited

Motivation for this change

Upgrade st from 0.7 to 0.8. Note that testing locally, the Delete key wasn't working with the patch (but worked without it), so I removed it, assuming the reason that caused it to be here was fixed upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @viric @andsild

@andsild
Copy link
Contributor

andsild commented Mar 15, 2018

The delete patch was not perfect anyway, didn't e.g. work in screen, so happy to have it removed :)

@gebner
Copy link
Member

gebner commented Mar 17, 2018

@GrahamcOfBorg build st

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: st

Partial log (click to expand)

Please see the README file regarding the terminfo entry of st.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8
shrinking /nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8/bin/st
gzipping man pages under /nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8/bin
patching script interpreter paths in /nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8
checking for references to /build in /nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8...
/nix/store/h9h7wy34sr9pwi4lzzhb5mdpi4bp3ym8-st-0.8

@gebner gebner merged commit fe8c36a into NixOS:master Mar 17, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: st

Partial log (click to expand)

Please see the README file regarding the terminfo entry of st.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8
shrinking /nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8/bin/st
gzipping man pages under /nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8/bin
patching script interpreter paths in /nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8
checking for references to /build in /nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8...
/nix/store/5i8pscdvpas5l7axa6d1kp1jnhv0gf80-st-0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ekleog @andsild @gebner @GrahamcOfBorg