edbrowse: 3.6.1 -> 3.7.2 #37077
Merged
edbrowse: 3.6.1 -> 3.7.2 #37077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using `make install` to ensure the non-versioned and major-versioned library symlinks are created.
Unmarked as broken, as the newer version uses duktape rather than an incompatible version of spidermonkey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update edbrowse to a version that is not broken WRT its dependencies (particularly, spidermonkey).
Things done
edbrowse version updated, newer version using duktape instead of spidermonkey.
duktape package fixed so it additionally produces symlinks to the real shared object files (nothing in nixpkgs previously depended on it, so this probably went unnoticed).
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)