Move some python modules from python-packages.nix #38207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etu
force-pushed
the
python-module-moves
branch
from
cb9e89f
to
b2f73cb
Compare
etu
force-pushed
the
python-module-moves
branch
from
b2f73cb
to
5345af4
Compare
etu
force-pushed
the
python-module-moves
branch
from
e3648c8
to
0f7ba50
Compare
GrahamcOfBorg
added
10.rebuild-darwin: 501+
and removed
10.rebuild-darwin: 101-500
labels
etu
force-pushed
the
python-module-moves
branch
2 times, most recently
from
eb40586
to
77adb75
Compare
|
@FRidh I'm feeling quite done with this for a while. I'll pick it up another day. Feel free to merge it if you think it's fine 😄 |
|
Has been included in #38439. Thank you very much for cleaning up the mess that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Just a plain move and cleanup of each module file, also a check that this specific module builds. No upgrades. Some changes of hashes to use the shorter format. One package that didn't build with python 3k got a disable line for that.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)