Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tamarin-prover: install vim syntax highlighting files #38260

Merged
merged 1 commit into from Apr 9, 2018
Merged

tamarin-prover: install vim syntax highlighting files #38260

merged 1 commit into from Apr 9, 2018

Conversation

symphorien
Copy link
Member

note that this was tested on 13e74a8
because tamarin-prover does not build on master...

Motivation for this change

Vim syntax highlighting files were not installed.

Things done

Tested as follows:

environment.etc.vimrc.source =
  let vimrcConfig = {
     packages.myVimPackages = {
        start = [ pkgs.tamarin-prover ];
    };
  };
  in 
  "${pkgs.vimUtils.vimrcFile vimrcConfig}";

@symphorien
tamarin-prover: install vim syntax highlighting files
d432cb7 
note that this was tested on 13e74a8
because tamarin-prover does not build on master...
@thoughtpolice thoughtpolice self-requested a review March 31, 2018 22:28
@thoughtpolice
Copy link
Member

Thanks -- I've been planning to get back to the Tamarin prover expression, I'll look into the build failure.

@infinisil
Copy link
Member

@GrahamcOfBorg build tamarin-prover

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tamarin-prover

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tamarin-prover

Partial log (click to expand)

302 | traceExceptions :: MonadBaseControl IO m => String -> m a -> m a
    |                    ^^^^^^^^^^^^^^^^

src/Web/Handler.hs:306:16: error:
    Not in scope: type constructor or class ‘MonadBaseControl’
    |
306 |     handler :: MonadBaseControl IO m => E.SomeException -> m a
    |                ^^^^^^^^^^^^^^^^
builder for '/nix/store/skjmd05k53vxl5x56ffcrda143ipvici-tamarin-prover-1.3.1.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/skjmd05k53vxl5x56ffcrda143ipvici-tamarin-prover-1.3.1.drv' failed

@matthewbauer matthewbauer merged commit 72a54f3 into NixOS:master Apr 9, 2018
@infinisil
Copy link
Member

@matthewbauer Why merge this when it doesn't build on master? Should be fixed first.

Should be easy to find the cause with git bisect

@matthewbauer
Copy link
Member

Cherrypicking 13e74a8 and it works for me. Obviously won't fix the build failure but it doesn't break anything either. Most likely it will need a Haskell override.

@matthewbauer
Copy link
Member

matthewbauer commented Apr 9, 2018 •
edited

Although in the future it's usually easier to have this config stuff included in the upstream Makefile.

@wchresta wchresta mentioned this pull request May 7, 2018
Closed
@symphorien symphorien deleted the tamarin-vim branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@symphorien @thoughtpolice @infinisil @GrahamcOfBorg @matthewbauer